Return-Path: X-Original-To: apmail-tez-issues-archive@minotaur.apache.org Delivered-To: apmail-tez-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 624BC187F0 for ; Tue, 2 Feb 2016 03:45:40 +0000 (UTC) Received: (qmail 22679 invoked by uid 500); 2 Feb 2016 03:45:40 -0000 Delivered-To: apmail-tez-issues-archive@tez.apache.org Received: (qmail 22625 invoked by uid 500); 2 Feb 2016 03:45:40 -0000 Mailing-List: contact issues-help@tez.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tez.apache.org Delivered-To: mailing list issues@tez.apache.org Received: (qmail 22612 invoked by uid 99); 2 Feb 2016 03:45:40 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Feb 2016 03:45:40 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id C12D82C0AFA for ; Tue, 2 Feb 2016 03:45:39 +0000 (UTC) Date: Tue, 2 Feb 2016 03:45:39 +0000 (UTC) From: "Bikas Saha (JIRA)" To: issues@tez.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (TEZ-3089) TaskConcurrencyAnalyzer can return negative task count with very large jobs MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/TEZ-3089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15127612#comment-15127612 ] Bikas Saha commented on TEZ-3089: --------------------------------- If either event has type other than start or finish then +1 will be return. Is that desired or should that only be o1=finish and o2=start? {code}+ if (o1.eventType.equals(EventType.START) + && o2.eventType.equals(EventType.FINISH)) { + return -1; + } else { + return 1; + } {code} > TaskConcurrencyAnalyzer can return negative task count with very large jobs > --------------------------------------------------------------------------- > > Key: TEZ-3089 > URL: https://issues.apache.org/jira/browse/TEZ-3089 > Project: Apache Tez > Issue Type: Bug > Reporter: Rajesh Balamohan > Attachments: TEZ-3089.1.patch > > > timeInfoset comparator should ideally include timestamp along with eventtype to work properly. -- This message was sent by Atlassian JIRA (v6.3.4#6332)