Return-Path: X-Original-To: apmail-tez-issues-archive@minotaur.apache.org Delivered-To: apmail-tez-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BC46C18257 for ; Mon, 6 Jul 2015 23:44:04 +0000 (UTC) Received: (qmail 54282 invoked by uid 500); 6 Jul 2015 23:44:04 -0000 Delivered-To: apmail-tez-issues-archive@tez.apache.org Received: (qmail 54217 invoked by uid 500); 6 Jul 2015 23:44:04 -0000 Mailing-List: contact issues-help@tez.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tez.apache.org Delivered-To: mailing list issues@tez.apache.org Received: (qmail 54204 invoked by uid 99); 6 Jul 2015 23:44:04 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 06 Jul 2015 23:44:04 +0000 Date: Mon, 6 Jul 2015 23:44:04 +0000 (UTC) From: "TezQA (JIRA)" To: issues@tez.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (TEZ-2591) Remove unneeded methods from EdgeManagerPludinOnDemand MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/TEZ-2591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14615907#comment-14615907 ] TezQA commented on TEZ-2591: ---------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12743817/TEZ-2591.2.patch against master revision cb59851. {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 4 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. There were no new javadoc warning messages. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 3.0.1) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 core tests{color}. The patch failed these unit tests in : org.apache.tez.dag.library.vertexmanager.TestShuffleVertexManager Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/885//testReport/ Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/885//console This message is automatically generated. > Remove unneeded methods from EdgeManagerPludinOnDemand > ------------------------------------------------------ > > Key: TEZ-2591 > URL: https://issues.apache.org/jira/browse/TEZ-2591 > Project: Apache Tez > Issue Type: Bug > Reporter: Bikas Saha > Assignee: Bikas Saha > Attachments: TEZ-2591.1.patch, TEZ-2591.2.patch > > > EdgeManagerPluginOnDemand inherits from EdgeManager (legacy) due to some common methods. Removing this dependency would be cleaner for the code. -- This message was sent by Atlassian JIRA (v6.3.4#6332)