tez-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "TezQA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TEZ-2575) Handle KeyValue pairs size which do not fit in a single block
Date Sat, 04 Jul 2015 10:49:04 GMT

    [ https://issues.apache.org/jira/browse/TEZ-2575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14613684#comment-14613684
] 

TezQA commented on TEZ-2575:
----------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest attachment
  http://issues.apache.org/jira/secure/attachment/12743564/TEZ-2575.5.patch
  against master revision aca8309.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified
test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
3.0.1) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/875//testReport/
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/875//console

This message is automatically generated.

> Handle KeyValue pairs size which do not fit in a single block
> -------------------------------------------------------------
>
>                 Key: TEZ-2575
>                 URL: https://issues.apache.org/jira/browse/TEZ-2575
>             Project: Apache Tez
>          Issue Type: Improvement
>            Reporter: Saikat
>            Assignee: Saikat
>         Attachments: TEZ-2575.1.patch, TEZ-2575.2.patch, TEZ-2575.3.patch, TEZ-2575.4.patch,
TEZ-2575.5.patch, TEZ-2575.patch
>
>
> In the present implementation, the available buffer is divided into blocks (specified
in the constructor for pipeline sort). and a linked list of these block byte buffers is maintained.

> A span is created out of the buffers. 
> The present logic, doesnot handle scenario where a single key-value pair size doesnot
fit into any of the blocks.
> example if 1mb total memory is divided into 4 blocks, (256 kb each),
> if a single KV pair is greater than the blocksize(~ignoring meta data size), 
> then it fails with buffer exceptions.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message