tez-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rajesh Balamohan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TEZ-1590) Fetchers should not report failures after the Processor on the task completes
Date Thu, 23 Oct 2014 04:37:33 GMT

    [ https://issues.apache.org/jira/browse/TEZ-1590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14181013#comment-14181013
] 

Rajesh Balamohan commented on TEZ-1590:
---------------------------------------

In Fetcher.java:
{code}
while (!remaining.isEmpty() && failedInputs == null) {
      if (isShutDown.get()) {
        shutdownInternal();
        LOG.info("Fetcher already shutdown. Aborting queued fetches for " + remaining.size()
+ " inputs");
        return new HostFetchResult(new FetchResult(host, port, partition, remaining), null,
            false);
      }
{code}

Should it be shutdownInternal(true)?  


In FetcherOrderedGrouped.java:
{code}
if (!header.mapId.startsWith(InputAttemptIdentifier.PATH_PREFIX)) {
          if (!stopped) {
            badIdErrs.increment(1);
            ....
{code}

Do we need to catch IllegalArgumentException,  as bad/wrong mapId doesn't throw any exception?


> Fetchers should not report failures after the Processor on the task completes
> -----------------------------------------------------------------------------
>
>                 Key: TEZ-1590
>                 URL: https://issues.apache.org/jira/browse/TEZ-1590
>             Project: Apache Tez
>          Issue Type: Bug
>    Affects Versions: 0.5.0
>            Reporter: Rohini Palaniswamy
>            Assignee: Siddharth Seth
>         Attachments: TEZ-1590.1.txt
>
>
> Details in https://issues.apache.org/jira/browse/PIG-4069?focusedCommentId=14136710&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14136710



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message