Mailing-List: contact issues-help@tez.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@tez.incubator.apache.org
Date: Wed, 7 Aug 2013 03:21:47 +0000 (UTC)
From: "joeyli (JIRA)" <jira@apache.org>
To: issues@tez.incubator.apache.org
Message-ID: <JIRA.12662034.1375765164500.13991.1375845707619@arcas>
In-Reply-To: <JIRA.12662034.1375765164500@arcas>
References: <JIRA.12662034.1375765164500@arcas>
Subject: [jira] [Comment Edited] (TEZ-346) AM should not use
 TezConfiguration objects
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/TEZ-346?page=3Dcom.atlassian.ji=
ra.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1373160=
1#comment-13731601 ]=20

joeyli edited comment on TEZ-346 at 8/7/13 3:21 AM:
----------------------------------------------------

A lot of TezConfiguration objects in DAGAppMaster, there isn't a neat way t=
o get rid of them. I think a better way is don't let TezConfiguration load =
tez-site.xml automatically.

I moved addDefaultResource(TEZ_SITE_XML) into the constructors, and add a n=
ew one to let the user decide whether load xml or not. A patch attached,ple=
ase take a look.

               =20
      was (Author: fiberlijun):
    A lot of TezConfiguration objects in DAGAppMaster, there isn't a neat w=
ay to get rid of them. I think a better way is don't let TezConfiguration l=
oad tez-site.xml automatically.I moved addDefaultResource(TEZ_SITE_XML) int=
o the constructors, and add a new one to let the user decide whether load x=
ml or not.

=E3=80=90code=3DJava=E3=80=91
public class TezConfiguration extends Configuration {

  public final static String TEZ_SITE_XML =3D "tez-site.xml";

  public TezConfiguration() {
    super();
    addDefaultResource(TEZ_SITE_XML);
  }

  public TezConfiguration(Configuration conf) {
    super(conf);
    addDefaultResource(TEZ_SITE_XML);
  }

  public TezConfiguration(Configuration conf,boolean loadXml) {
    super(conf);
    if(loadXml)
      addDefaultResource(TEZ_SITE_XML);
  }
=E3=80=90/code=E3=80=91
                 =20
> AM should not use TezConfiguration objects
> ------------------------------------------
>
>                 Key: TEZ-346
>                 URL: https://issues.apache.org/jira/browse/TEZ-346
>             Project: Apache Tez
>          Issue Type: Bug
>            Reporter: Siddharth Seth
>            Assignee: Hitesh Shah
>
> Or avoid loading tez-site.xml each time Tez configuration is set.
> AM configuration is supposed to be specified by the client. If tez-site h=
appens to be deployed on all nodes - the AM ends up reading this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrato=
rs
For more information on JIRA, see: http://www.atlassian.com/software/jira