Return-Path: X-Original-To: apmail-tez-issues-archive@minotaur.apache.org Delivered-To: apmail-tez-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 40637F308 for ; Tue, 6 Aug 2013 05:22:11 +0000 (UTC) Received: (qmail 22169 invoked by uid 500); 6 Aug 2013 05:22:11 -0000 Delivered-To: apmail-tez-issues-archive@tez.apache.org Received: (qmail 22143 invoked by uid 500); 6 Aug 2013 05:22:11 -0000 Mailing-List: contact issues-help@tez.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tez.incubator.apache.org Delivered-To: mailing list issues@tez.incubator.apache.org Received: (qmail 22136 invoked by uid 99); 6 Aug 2013 05:22:10 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Aug 2013 05:22:10 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Tue, 06 Aug 2013 05:22:09 +0000 Received: (qmail 21444 invoked by uid 99); 6 Aug 2013 05:21:48 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Aug 2013 05:21:48 +0000 Date: Tue, 6 Aug 2013 05:21:48 +0000 (UTC) From: "Siddharth Seth (JIRA)" To: issues@tez.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (TEZ-334) There are redundant variables in MultiStageMRConfToTezTranslator.getStageConfs MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/TEZ-334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13730368#comment-13730368 ] Siddharth Seth commented on TEZ-334: ------------------------------------ Change look good. [~zeustencent] could you please post this as a patch ? > There are redundant variables in MultiStageMRConfToTezTranslator.getStageConfs > ------------------------------------------------------------------------------ > > Key: TEZ-334 > URL: https://issues.apache.org/jira/browse/TEZ-334 > Project: Apache Tez > Issue Type: Improvement > Reporter: jiang jie > Priority: Minor > > MultiStageMRConfToTezTranslator.getStageConfs uses three local variables as follows > int totalStages = numIntermediateStages + (hasFinalReduceStage ? 2 : 1); > int numEdges = totalStages - 1; > int numStages = numEdges + 1; > The numStages is equal to the totalStages and only the numStages is used later, therefore we can only use one local variable. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira