tez-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "joeyli (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (TEZ-346) AM should not use TezConfiguration objects
Date Wed, 07 Aug 2013 03:21:47 GMT

    [ https://issues.apache.org/jira/browse/TEZ-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13731601#comment-13731601
] 

joeyli edited comment on TEZ-346 at 8/7/13 3:21 AM:
----------------------------------------------------

A lot of TezConfiguration objects in DAGAppMaster, there isn't a neat way to get rid of them.
I think a better way is don't let TezConfiguration load tez-site.xml automatically.

I moved addDefaultResource(TEZ_SITE_XML) into the constructors, and add a new one to let the
user decide whether load xml or not. A patch attached,please take a look.

                
      was (Author: fiberlijun):
    A lot of TezConfiguration objects in DAGAppMaster, there isn't a neat way to get rid of
them. I think a better way is don't let TezConfiguration load tez-site.xml automatically.I
moved addDefaultResource(TEZ_SITE_XML) into the constructors, and add a new one to let the
user decide whether load xml or not.

【code=Java】
public class TezConfiguration extends Configuration {

  public final static String TEZ_SITE_XML = "tez-site.xml";

  public TezConfiguration() {
    super();
    addDefaultResource(TEZ_SITE_XML);
  }

  public TezConfiguration(Configuration conf) {
    super(conf);
    addDefaultResource(TEZ_SITE_XML);
  }

  public TezConfiguration(Configuration conf,boolean loadXml) {
    super(conf);
    if(loadXml)
      addDefaultResource(TEZ_SITE_XML);
  }
【/code】
                  
> AM should not use TezConfiguration objects
> ------------------------------------------
>
>                 Key: TEZ-346
>                 URL: https://issues.apache.org/jira/browse/TEZ-346
>             Project: Apache Tez
>          Issue Type: Bug
>            Reporter: Siddharth Seth
>            Assignee: Hitesh Shah
>
> Or avoid loading tez-site.xml each time Tez configuration is set.
> AM configuration is supposed to be specified by the client. If tez-site happens to be
deployed on all nodes - the AM ends up reading this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message