tez-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Siddharth Seth (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TEZ-334) There are redundant variables in MultiStageMRConfToTezTranslator.getStageConfs
Date Tue, 06 Aug 2013 05:21:48 GMT

    [ https://issues.apache.org/jira/browse/TEZ-334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13730368#comment-13730368
] 

Siddharth Seth commented on TEZ-334:
------------------------------------

Change look good. [~zeustencent] could you please post this as a patch ?
                
> There are redundant variables in MultiStageMRConfToTezTranslator.getStageConfs
> ------------------------------------------------------------------------------
>
>                 Key: TEZ-334
>                 URL: https://issues.apache.org/jira/browse/TEZ-334
>             Project: Apache Tez
>          Issue Type: Improvement
>            Reporter: jiang jie
>            Priority: Minor
>
> MultiStageMRConfToTezTranslator.getStageConfs uses three local variables as follows
>     int totalStages = numIntermediateStages + (hasFinalReduceStage ? 2 : 1);
>     int numEdges = totalStages - 1;
>     int numStages = numEdges + 1;
> The numStages is equal to the totalStages and only the numStages is used later, therefore
we can only use one local variable.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message