Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id D8E6A200CF7 for ; Tue, 19 Sep 2017 20:25:28 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id D63291609DD; Tue, 19 Sep 2017 18:25:28 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 283AE1609BF for ; Tue, 19 Sep 2017 20:25:28 +0200 (CEST) Received: (qmail 24804 invoked by uid 500); 19 Sep 2017 18:25:27 -0000 Mailing-List: contact commits-help@tez.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tez.apache.org Delivered-To: mailing list commits@tez.apache.org Received: (qmail 24784 invoked by uid 99); 19 Sep 2017 18:25:27 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 19 Sep 2017 18:25:27 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 39E07E7DF9; Tue, 19 Sep 2017 18:25:27 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: jeagles@apache.org To: commits@tez.apache.org Message-Id: X-Mailer: ASF-Git Admin Mailer Subject: tez git commit: TEZ-3839. Tez Shuffle Handler prints disk error stack traces for every read failure. (Kuhu Shukla via jeagles) Date: Tue, 19 Sep 2017 18:25:27 +0000 (UTC) archived-at: Tue, 19 Sep 2017 18:25:29 -0000 Repository: tez Updated Branches: refs/heads/master f86128a8d -> 83a8b5097 TEZ-3839. Tez Shuffle Handler prints disk error stack traces for every read failure. (Kuhu Shukla via jeagles) Project: http://git-wip-us.apache.org/repos/asf/tez/repo Commit: http://git-wip-us.apache.org/repos/asf/tez/commit/83a8b509 Tree: http://git-wip-us.apache.org/repos/asf/tez/tree/83a8b509 Diff: http://git-wip-us.apache.org/repos/asf/tez/diff/83a8b509 Branch: refs/heads/master Commit: 83a8b5097ef3bebc81d85f551ca2d7ba0fbb2e05 Parents: f86128a Author: Jonathan Eagles Authored: Tue Sep 19 13:25:21 2017 -0500 Committer: Jonathan Eagles Committed: Tue Sep 19 13:25:21 2017 -0500 ---------------------------------------------------------------------- .../main/java/org/apache/tez/auxservices/ShuffleHandler.java | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/tez/blob/83a8b509/tez-plugins/tez-aux-services/src/main/java/org/apache/tez/auxservices/ShuffleHandler.java ---------------------------------------------------------------------- diff --git a/tez-plugins/tez-aux-services/src/main/java/org/apache/tez/auxservices/ShuffleHandler.java b/tez-plugins/tez-aux-services/src/main/java/org/apache/tez/auxservices/ShuffleHandler.java index a4d1495..d48cc01 100644 --- a/tez-plugins/tez-aux-services/src/main/java/org/apache/tez/auxservices/ShuffleHandler.java +++ b/tez-plugins/tez-aux-services/src/main/java/org/apache/tez/auxservices/ShuffleHandler.java @@ -18,6 +18,7 @@ package org.apache.tez.auxservices; +import org.apache.hadoop.util.DiskChecker; import static org.fusesource.leveldbjni.JniDBFactory.asString; import static org.fusesource.leveldbjni.JniDBFactory.bytes; import static org.jboss.netty.buffer.ChannelBuffers.wrappedBuffer; @@ -1160,7 +1161,11 @@ public class ShuffleHandler extends AuxiliaryService { } nextMap.addListener(new ReduceMapFileCount(reduceContext)); } catch (IOException e) { - LOG.error("Shuffle error :", e); + if (e instanceof DiskChecker.DiskErrorException) { + LOG.error("Shuffle error :" + e); + } else { + LOG.error("Shuffle error :", e); + } String errorMessage = getErrorMessage(e); sendError(reduceContext.getCtx(), errorMessage, INTERNAL_SERVER_ERROR);