tez-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zhiyu...@apache.org
Subject [02/11] tez git commit: TEZ-3786. Fix Tez UI test failures after TEZ-3775 (jeagles)
Date Fri, 14 Jul 2017 18:05:28 GMT
TEZ-3786. Fix Tez UI test failures after TEZ-3775 (jeagles)


Project: http://git-wip-us.apache.org/repos/asf/tez/repo
Commit: http://git-wip-us.apache.org/repos/asf/tez/commit/487beeec
Tree: http://git-wip-us.apache.org/repos/asf/tez/tree/487beeec
Diff: http://git-wip-us.apache.org/repos/asf/tez/diff/487beeec

Branch: refs/heads/branch-0.9.0
Commit: 487beeec5762586fbdabefc9ae9d2f3fe67705fc
Parents: 3d665f9
Author: Jonathan Eagles <jeagles@yahoo-inc.com>
Authored: Mon Jul 10 09:58:19 2017 -0500
Committer: Jonathan Eagles <jeagles@yahoo-inc.com>
Committed: Mon Jul 10 09:58:19 2017 -0500

----------------------------------------------------------------------
 .../src/main/webapp/tests/unit/routes/app/configs-test.js | 10 ++++++++--
 tez-ui/src/main/webapp/tests/unit/routes/app/dags-test.js | 10 ++++++++--
 .../src/main/webapp/tests/unit/routes/app/index-test.js   | 10 ++++++++--
 .../webapp/tests/unit/routes/attempt/counters-test.js     |  9 ++++++++-
 .../main/webapp/tests/unit/routes/attempt/index-test.js   | 10 ++++++++--
 .../main/webapp/tests/unit/routes/dag/attempts-test.js    |  9 ++++++++-
 .../main/webapp/tests/unit/routes/dag/counters-test.js    |  9 ++++++++-
 .../src/main/webapp/tests/unit/routes/dag/index-test.js   |  8 +++++++-
 .../main/webapp/tests/unit/routes/dag/index/index-test.js |  9 ++++++++-
 .../main/webapp/tests/unit/routes/dag/swimlane-test.js    |  9 ++++++++-
 .../src/main/webapp/tests/unit/routes/dag/tasks-test.js   |  8 +++++++-
 .../main/webapp/tests/unit/routes/dag/vertices-test.js    |  9 ++++++++-
 .../main/webapp/tests/unit/routes/task/attempts-test.js   |  9 ++++++++-
 .../main/webapp/tests/unit/routes/task/counters-test.js   |  9 ++++++++-
 .../src/main/webapp/tests/unit/routes/task/index-test.js  |  9 ++++++++-
 .../main/webapp/tests/unit/routes/vertex/attempts-test.js |  9 ++++++++-
 .../main/webapp/tests/unit/routes/vertex/configs-test.js  |  9 ++++++++-
 .../main/webapp/tests/unit/routes/vertex/counters-test.js |  9 ++++++++-
 .../main/webapp/tests/unit/routes/vertex/index-test.js    |  9 ++++++++-
 .../main/webapp/tests/unit/routes/vertex/tasks-test.js    |  8 +++++++-
 20 files changed, 157 insertions(+), 24 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/tez/blob/487beeec/tez-ui/src/main/webapp/tests/unit/routes/app/configs-test.js
----------------------------------------------------------------------
diff --git a/tez-ui/src/main/webapp/tests/unit/routes/app/configs-test.js b/tez-ui/src/main/webapp/tests/unit/routes/app/configs-test.js
index 3df332b..6a5394d 100644
--- a/tez-ui/src/main/webapp/tests/unit/routes/app/configs-test.js
+++ b/tez-ui/src/main/webapp/tests/unit/routes/app/configs-test.js
@@ -36,9 +36,15 @@ test('Basic creation test', function(assert) {
 });
 
 test('setupController test', function(assert) {
-  assert.expect(1);
+  assert.expect(2);
 
   let route = this.subject({
+    modelFor: function (type) {
+      assert.equal(type, 'app');
+      return Ember.Object.create({
+        entityID: 'app_123'
+      });
+    },
     startCrumbBubble: function () {
       assert.ok(true);
     }
@@ -94,4 +100,4 @@ test('load failure test', function(assert) {
   });
 
   assert.expect(1 + 2);
-});
\ No newline at end of file
+});

http://git-wip-us.apache.org/repos/asf/tez/blob/487beeec/tez-ui/src/main/webapp/tests/unit/routes/app/dags-test.js
----------------------------------------------------------------------
diff --git a/tez-ui/src/main/webapp/tests/unit/routes/app/dags-test.js b/tez-ui/src/main/webapp/tests/unit/routes/app/dags-test.js
index 82ee9d1..7b73324 100644
--- a/tez-ui/src/main/webapp/tests/unit/routes/app/dags-test.js
+++ b/tez-ui/src/main/webapp/tests/unit/routes/app/dags-test.js
@@ -36,9 +36,15 @@ test('Basic creation test', function(assert) {
 });
 
 test('setupController test', function(assert) {
-  assert.expect(1);
+  assert.expect(2);
 
   let route = this.subject({
+    modelFor: function (type) {
+      assert.equal(type, 'app');
+      return Ember.Object.create({
+        entityID: 'app_123'
+      });
+    },
     startCrumbBubble: function () {
       assert.ok(true);
     }
@@ -75,4 +81,4 @@ test('Test load', function(assert) {
 
   data = route.load(null, null, testOptions);
   assert.equal(data, testData);
-});
\ No newline at end of file
+});

http://git-wip-us.apache.org/repos/asf/tez/blob/487beeec/tez-ui/src/main/webapp/tests/unit/routes/app/index-test.js
----------------------------------------------------------------------
diff --git a/tez-ui/src/main/webapp/tests/unit/routes/app/index-test.js b/tez-ui/src/main/webapp/tests/unit/routes/app/index-test.js
index ef5917c..02aed78 100644
--- a/tez-ui/src/main/webapp/tests/unit/routes/app/index-test.js
+++ b/tez-ui/src/main/webapp/tests/unit/routes/app/index-test.js
@@ -36,9 +36,15 @@ test('Basic creation test', function(assert) {
 });
 
 test('setupController test', function(assert) {
-  assert.expect(1);
+  assert.expect(2);
 
   let route = this.subject({
+    modelFor: function (type) {
+      assert.equal(type, 'app');
+      return Ember.Object.create({
+        entityID: 'app_123'
+      });
+    },
     startCrumbBubble: function () {
       assert.ok(true);
     }
@@ -90,4 +96,4 @@ test('Test load', function(assert) {
   assert.throws(function () {
     route.load(null, null, testOptions);
   });
-});
\ No newline at end of file
+});

http://git-wip-us.apache.org/repos/asf/tez/blob/487beeec/tez-ui/src/main/webapp/tests/unit/routes/attempt/counters-test.js
----------------------------------------------------------------------
diff --git a/tez-ui/src/main/webapp/tests/unit/routes/attempt/counters-test.js b/tez-ui/src/main/webapp/tests/unit/routes/attempt/counters-test.js
index 4d47431..f818c2b 100644
--- a/tez-ui/src/main/webapp/tests/unit/routes/attempt/counters-test.js
+++ b/tez-ui/src/main/webapp/tests/unit/routes/attempt/counters-test.js
@@ -16,6 +16,7 @@
  * limitations under the License.
  */
 
+import Ember from 'ember';
 import { moduleFor, test } from 'ember-qunit';
 
 moduleFor('route:attempt/counters', 'Unit | Route | attempt/counters', {
@@ -34,9 +35,15 @@ test('Basic creation test', function(assert) {
 });
 
 test('setupController test', function(assert) {
-  assert.expect(1);
+  assert.expect(2);
 
   let route = this.subject({
+    modelFor: function (type) {
+      assert.equal(type, 'attempt');
+      return Ember.Object.create({
+        entityID: 'attempt_123'
+      });
+    },
     startCrumbBubble: function () {
       assert.ok(true);
     }

http://git-wip-us.apache.org/repos/asf/tez/blob/487beeec/tez-ui/src/main/webapp/tests/unit/routes/attempt/index-test.js
----------------------------------------------------------------------
diff --git a/tez-ui/src/main/webapp/tests/unit/routes/attempt/index-test.js b/tez-ui/src/main/webapp/tests/unit/routes/attempt/index-test.js
index 69877da..8e5f02e 100644
--- a/tez-ui/src/main/webapp/tests/unit/routes/attempt/index-test.js
+++ b/tez-ui/src/main/webapp/tests/unit/routes/attempt/index-test.js
@@ -15,7 +15,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-
+import Ember from 'ember';
 import { moduleFor, test } from 'ember-qunit';
 
 moduleFor('route:attempt/index', 'Unit | Route | attempt/index', {
@@ -34,9 +34,15 @@ test('Basic creation test', function(assert) {
 });
 
 test('setupController test', function(assert) {
-  assert.expect(1);
+  assert.expect(2);
 
   let route = this.subject({
+    modelFor: function (type) {
+      assert.equal(type, 'attempt');
+      return Ember.Object.create({
+        entityID: 'attempt_123'
+      });
+    },
     startCrumbBubble: function () {
       assert.ok(true);
     }

http://git-wip-us.apache.org/repos/asf/tez/blob/487beeec/tez-ui/src/main/webapp/tests/unit/routes/dag/attempts-test.js
----------------------------------------------------------------------
diff --git a/tez-ui/src/main/webapp/tests/unit/routes/dag/attempts-test.js b/tez-ui/src/main/webapp/tests/unit/routes/dag/attempts-test.js
index 78dd520..e481fe2 100644
--- a/tez-ui/src/main/webapp/tests/unit/routes/dag/attempts-test.js
+++ b/tez-ui/src/main/webapp/tests/unit/routes/dag/attempts-test.js
@@ -16,6 +16,7 @@
  * limitations under the License.
  */
 
+import Ember from 'ember';
 import { moduleFor, test } from 'ember-qunit';
 
 moduleFor('route:dag/attempts', 'Unit | Route | dag/attempts', {
@@ -34,9 +35,15 @@ test('Basic creation test', function(assert) {
 });
 
 test('setupController test', function(assert) {
-  assert.expect(1);
+  assert.expect(2);
 
   let route = this.subject({
+    modelFor: function (type) {
+      assert.equal(type, 'dag');
+      return Ember.Object.create({
+        entityID: 'dag_123'
+      });
+    },
     startCrumbBubble: function () {
       assert.ok(true);
     }

http://git-wip-us.apache.org/repos/asf/tez/blob/487beeec/tez-ui/src/main/webapp/tests/unit/routes/dag/counters-test.js
----------------------------------------------------------------------
diff --git a/tez-ui/src/main/webapp/tests/unit/routes/dag/counters-test.js b/tez-ui/src/main/webapp/tests/unit/routes/dag/counters-test.js
index d2cd66e..2df49fe 100644
--- a/tez-ui/src/main/webapp/tests/unit/routes/dag/counters-test.js
+++ b/tez-ui/src/main/webapp/tests/unit/routes/dag/counters-test.js
@@ -16,6 +16,7 @@
  * limitations under the License.
  */
 
+import Ember from 'ember';
 import { moduleFor, test } from 'ember-qunit';
 
 moduleFor('route:dag/counters', 'Unit | Route | dag/counters', {
@@ -34,9 +35,15 @@ test('Basic creation test', function(assert) {
 });
 
 test('setupController test', function(assert) {
-  assert.expect(1);
+  assert.expect(2);
 
   let route = this.subject({
+    modelFor: function (type) {
+      assert.equal(type, 'dag');
+      return Ember.Object.create({
+        entityID: 'dag_123'
+      });
+    },
     startCrumbBubble: function () {
       assert.ok(true);
     }

http://git-wip-us.apache.org/repos/asf/tez/blob/487beeec/tez-ui/src/main/webapp/tests/unit/routes/dag/index-test.js
----------------------------------------------------------------------
diff --git a/tez-ui/src/main/webapp/tests/unit/routes/dag/index-test.js b/tez-ui/src/main/webapp/tests/unit/routes/dag/index-test.js
index b7ee27f..196c532 100644
--- a/tez-ui/src/main/webapp/tests/unit/routes/dag/index-test.js
+++ b/tez-ui/src/main/webapp/tests/unit/routes/dag/index-test.js
@@ -36,9 +36,15 @@ test('Basic creation test', function(assert) {
 });
 
 test('setupController test', function(assert) {
-  assert.expect(1);
+  assert.expect(2);
 
   let route = this.subject({
+    modelFor: function (type) {
+      assert.equal(type, 'dag');
+      return Ember.Object.create({
+        entityID: 'dag_123'
+      });
+    },
     startCrumbBubble: function () {
       assert.ok(true);
     }

http://git-wip-us.apache.org/repos/asf/tez/blob/487beeec/tez-ui/src/main/webapp/tests/unit/routes/dag/index/index-test.js
----------------------------------------------------------------------
diff --git a/tez-ui/src/main/webapp/tests/unit/routes/dag/index/index-test.js b/tez-ui/src/main/webapp/tests/unit/routes/dag/index/index-test.js
index dc767ba..b49a9d1 100644
--- a/tez-ui/src/main/webapp/tests/unit/routes/dag/index/index-test.js
+++ b/tez-ui/src/main/webapp/tests/unit/routes/dag/index/index-test.js
@@ -16,6 +16,7 @@
  * limitations under the License.
  */
 
+import Ember from 'ember';
 import { moduleFor, test } from 'ember-qunit';
 
 moduleFor('route:dag/index/index', 'Unit | Route | dag/index/index', {
@@ -38,9 +39,15 @@ test('Basic creation test', function(assert) {
 });
 
 test('setupController test', function(assert) {
-  assert.expect(1);
+  assert.expect(2);
 
   let route = this.subject({
+    modelFor: function (type) {
+      assert.equal(type, 'dag');
+      return Ember.Object.create({
+        entityID: 'dag_123'
+      });
+    },
     startCrumbBubble: function () {
       assert.ok(true);
     }

http://git-wip-us.apache.org/repos/asf/tez/blob/487beeec/tez-ui/src/main/webapp/tests/unit/routes/dag/swimlane-test.js
----------------------------------------------------------------------
diff --git a/tez-ui/src/main/webapp/tests/unit/routes/dag/swimlane-test.js b/tez-ui/src/main/webapp/tests/unit/routes/dag/swimlane-test.js
index 8d0197f..123f69b 100644
--- a/tez-ui/src/main/webapp/tests/unit/routes/dag/swimlane-test.js
+++ b/tez-ui/src/main/webapp/tests/unit/routes/dag/swimlane-test.js
@@ -16,6 +16,7 @@
  * limitations under the License.
  */
 
+import Ember from 'ember';
 import { moduleFor, test } from 'ember-qunit';
 
 moduleFor('route:dag/swimlane', 'Unit | Route | dag/swimlane', {
@@ -34,9 +35,15 @@ test('Basic creation test', function(assert) {
 });
 
 test('setupController test', function(assert) {
-  assert.expect(1);
+  assert.expect(2);
 
   let route = this.subject({
+    modelFor: function (type) {
+      assert.equal(type, 'dag');
+      return Ember.Object.create({
+        entityID: 'dag_123'
+      });
+    },
     startCrumbBubble: function () {
       assert.ok(true);
     }

http://git-wip-us.apache.org/repos/asf/tez/blob/487beeec/tez-ui/src/main/webapp/tests/unit/routes/dag/tasks-test.js
----------------------------------------------------------------------
diff --git a/tez-ui/src/main/webapp/tests/unit/routes/dag/tasks-test.js b/tez-ui/src/main/webapp/tests/unit/routes/dag/tasks-test.js
index 887246d..2dfa404 100644
--- a/tez-ui/src/main/webapp/tests/unit/routes/dag/tasks-test.js
+++ b/tez-ui/src/main/webapp/tests/unit/routes/dag/tasks-test.js
@@ -37,9 +37,15 @@ test('Basic creation test', function(assert) {
 });
 
 test('setupController test', function(assert) {
-  assert.expect(1);
+  assert.expect(2);
 
   let route = this.subject({
+    modelFor: function (type) {
+      assert.equal(type, 'dag');
+      return Ember.Object.create({
+        entityID: 'dag_123'
+      });
+    },
     startCrumbBubble: function () {
       assert.ok(true);
     }

http://git-wip-us.apache.org/repos/asf/tez/blob/487beeec/tez-ui/src/main/webapp/tests/unit/routes/dag/vertices-test.js
----------------------------------------------------------------------
diff --git a/tez-ui/src/main/webapp/tests/unit/routes/dag/vertices-test.js b/tez-ui/src/main/webapp/tests/unit/routes/dag/vertices-test.js
index b8d2f2e..b2b8e7b 100644
--- a/tez-ui/src/main/webapp/tests/unit/routes/dag/vertices-test.js
+++ b/tez-ui/src/main/webapp/tests/unit/routes/dag/vertices-test.js
@@ -16,6 +16,7 @@
  * limitations under the License.
  */
 
+import Ember from 'ember';
 import { moduleFor, test } from 'ember-qunit';
 
 moduleFor('route:dag/vertices', 'Unit | Route | dag/vertices', {
@@ -34,9 +35,15 @@ test('Basic creation test', function(assert) {
 });
 
 test('setupController test', function(assert) {
-  assert.expect(1);
+  assert.expect(2);
 
   let route = this.subject({
+    modelFor: function (type) {
+      assert.equal(type, 'dag');
+      return Ember.Object.create({
+        entityID: 'dag_123'
+      });
+    },
     startCrumbBubble: function () {
       assert.ok(true);
     }

http://git-wip-us.apache.org/repos/asf/tez/blob/487beeec/tez-ui/src/main/webapp/tests/unit/routes/task/attempts-test.js
----------------------------------------------------------------------
diff --git a/tez-ui/src/main/webapp/tests/unit/routes/task/attempts-test.js b/tez-ui/src/main/webapp/tests/unit/routes/task/attempts-test.js
index b38cc6f..ee02b71 100644
--- a/tez-ui/src/main/webapp/tests/unit/routes/task/attempts-test.js
+++ b/tez-ui/src/main/webapp/tests/unit/routes/task/attempts-test.js
@@ -16,6 +16,7 @@
  * limitations under the License.
  */
 
+import Ember from 'ember';
 import { moduleFor, test } from 'ember-qunit';
 
 moduleFor('route:task/attempts', 'Unit | Route | task/attempts', {
@@ -34,9 +35,15 @@ test('Basic creation test', function(assert) {
 });
 
 test('setupController test', function(assert) {
-  assert.expect(1);
+  assert.expect(2);
 
   let route = this.subject({
+    modelFor: function (type) {
+      assert.equal(type, 'task');
+      return Ember.Object.create({
+        entityID: 'task_123'
+      });
+    },
     startCrumbBubble: function () {
       assert.ok(true);
     }

http://git-wip-us.apache.org/repos/asf/tez/blob/487beeec/tez-ui/src/main/webapp/tests/unit/routes/task/counters-test.js
----------------------------------------------------------------------
diff --git a/tez-ui/src/main/webapp/tests/unit/routes/task/counters-test.js b/tez-ui/src/main/webapp/tests/unit/routes/task/counters-test.js
index 87895aa..a7ad7d2 100644
--- a/tez-ui/src/main/webapp/tests/unit/routes/task/counters-test.js
+++ b/tez-ui/src/main/webapp/tests/unit/routes/task/counters-test.js
@@ -16,6 +16,7 @@
  * limitations under the License.
  */
 
+import Ember from 'ember';
 import { moduleFor, test } from 'ember-qunit';
 
 moduleFor('route:task/counters', 'Unit | Route | task/counters', {
@@ -34,9 +35,15 @@ test('Basic creation test', function(assert) {
 });
 
 test('setupController test', function(assert) {
-  assert.expect(1);
+  assert.expect(2);
 
   let route = this.subject({
+    modelFor: function (type) {
+      assert.equal(type, 'task');
+      return Ember.Object.create({
+        entityID: 'task_123'
+      });
+    },
     startCrumbBubble: function () {
       assert.ok(true);
     }

http://git-wip-us.apache.org/repos/asf/tez/blob/487beeec/tez-ui/src/main/webapp/tests/unit/routes/task/index-test.js
----------------------------------------------------------------------
diff --git a/tez-ui/src/main/webapp/tests/unit/routes/task/index-test.js b/tez-ui/src/main/webapp/tests/unit/routes/task/index-test.js
index 4d95108..d334184 100644
--- a/tez-ui/src/main/webapp/tests/unit/routes/task/index-test.js
+++ b/tez-ui/src/main/webapp/tests/unit/routes/task/index-test.js
@@ -16,6 +16,7 @@
  * limitations under the License.
  */
 
+import Ember from 'ember';
 import { moduleFor, test } from 'ember-qunit';
 
 moduleFor('route:task/index', 'Unit | Route | task/index', {
@@ -36,9 +37,15 @@ test('Basic creation test', function(assert) {
 });
 
 test('setupController test', function(assert) {
-  assert.expect(1);
+  assert.expect(2);
 
   let route = this.subject({
+    modelFor: function (type) {
+      assert.equal(type, 'task');
+      return Ember.Object.create({
+        entityID: 'task_123'
+      });
+    },
     startCrumbBubble: function () {
       assert.ok(true);
     }

http://git-wip-us.apache.org/repos/asf/tez/blob/487beeec/tez-ui/src/main/webapp/tests/unit/routes/vertex/attempts-test.js
----------------------------------------------------------------------
diff --git a/tez-ui/src/main/webapp/tests/unit/routes/vertex/attempts-test.js b/tez-ui/src/main/webapp/tests/unit/routes/vertex/attempts-test.js
index 250a3b5..5aafe59 100644
--- a/tez-ui/src/main/webapp/tests/unit/routes/vertex/attempts-test.js
+++ b/tez-ui/src/main/webapp/tests/unit/routes/vertex/attempts-test.js
@@ -16,6 +16,7 @@
  * limitations under the License.
  */
 
+import Ember from 'ember';
 import { moduleFor, test } from 'ember-qunit';
 
 moduleFor('route:vertex/attempts', 'Unit | Route | vertex/attempts', {
@@ -34,9 +35,15 @@ test('Basic creation test', function(assert) {
 });
 
 test('setupController test', function(assert) {
-  assert.expect(1);
+  assert.expect(2);
 
   let route = this.subject({
+    modelFor: function (type) {
+      assert.equal(type, 'vertex');
+      return Ember.Object.create({
+        entityID: 'vertex_123'
+      });
+    },
     startCrumbBubble: function () {
       assert.ok(true);
     }

http://git-wip-us.apache.org/repos/asf/tez/blob/487beeec/tez-ui/src/main/webapp/tests/unit/routes/vertex/configs-test.js
----------------------------------------------------------------------
diff --git a/tez-ui/src/main/webapp/tests/unit/routes/vertex/configs-test.js b/tez-ui/src/main/webapp/tests/unit/routes/vertex/configs-test.js
index e293a7e..36a0df3 100644
--- a/tez-ui/src/main/webapp/tests/unit/routes/vertex/configs-test.js
+++ b/tez-ui/src/main/webapp/tests/unit/routes/vertex/configs-test.js
@@ -16,6 +16,7 @@
  * limitations under the License.
  */
 
+import Ember from 'ember';
 import { moduleFor, test } from 'ember-qunit';
 
 moduleFor('route:vertex/configs', 'Unit | Route | vertex/configs', {
@@ -34,9 +35,15 @@ test('Basic creation test', function(assert) {
 });
 
 test('setupController test', function(assert) {
-  assert.expect(1);
+  assert.expect(2);
 
   let route = this.subject({
+    modelFor: function (type) {
+      assert.equal(type, 'vertex');
+      return Ember.Object.create({
+        entityID: 'vertex_123'
+      });
+    },
     startCrumbBubble: function () {
       assert.ok(true);
     }

http://git-wip-us.apache.org/repos/asf/tez/blob/487beeec/tez-ui/src/main/webapp/tests/unit/routes/vertex/counters-test.js
----------------------------------------------------------------------
diff --git a/tez-ui/src/main/webapp/tests/unit/routes/vertex/counters-test.js b/tez-ui/src/main/webapp/tests/unit/routes/vertex/counters-test.js
index 9c14e8f..92905f0 100644
--- a/tez-ui/src/main/webapp/tests/unit/routes/vertex/counters-test.js
+++ b/tez-ui/src/main/webapp/tests/unit/routes/vertex/counters-test.js
@@ -16,6 +16,7 @@
  * limitations under the License.
  */
 
+import Ember from 'ember';
 import { moduleFor, test } from 'ember-qunit';
 
 moduleFor('route:vertex/counters', 'Unit | Route | vertex/counters', {
@@ -34,9 +35,15 @@ test('Basic creation test', function(assert) {
 });
 
 test('setupController test', function(assert) {
-  assert.expect(1);
+  assert.expect(2);
 
   let route = this.subject({
+    modelFor: function (type) {
+      assert.equal(type, 'vertex');
+      return Ember.Object.create({
+        entityID: 'vertex_123'
+      });
+    },
     startCrumbBubble: function () {
       assert.ok(true);
     }

http://git-wip-us.apache.org/repos/asf/tez/blob/487beeec/tez-ui/src/main/webapp/tests/unit/routes/vertex/index-test.js
----------------------------------------------------------------------
diff --git a/tez-ui/src/main/webapp/tests/unit/routes/vertex/index-test.js b/tez-ui/src/main/webapp/tests/unit/routes/vertex/index-test.js
index bab59b6..6587604 100644
--- a/tez-ui/src/main/webapp/tests/unit/routes/vertex/index-test.js
+++ b/tez-ui/src/main/webapp/tests/unit/routes/vertex/index-test.js
@@ -16,6 +16,7 @@
  * limitations under the License.
  */
 
+import Ember from 'ember';
 import { moduleFor, test } from 'ember-qunit';
 
 moduleFor('route:vertex/index', 'Unit | Route | vertex/index', {
@@ -34,9 +35,15 @@ test('Basic creation test', function(assert) {
 });
 
 test('setupController test', function(assert) {
-  assert.expect(1);
+  assert.expect(2);
 
   let route = this.subject({
+    modelFor: function (type) {
+      assert.equal(type, 'vertex');
+      return Ember.Object.create({
+        entityID: 'vertex_123'
+      });
+    },
     startCrumbBubble: function () {
       assert.ok(true);
     }

http://git-wip-us.apache.org/repos/asf/tez/blob/487beeec/tez-ui/src/main/webapp/tests/unit/routes/vertex/tasks-test.js
----------------------------------------------------------------------
diff --git a/tez-ui/src/main/webapp/tests/unit/routes/vertex/tasks-test.js b/tez-ui/src/main/webapp/tests/unit/routes/vertex/tasks-test.js
index 736ecf2..b0239ee 100644
--- a/tez-ui/src/main/webapp/tests/unit/routes/vertex/tasks-test.js
+++ b/tez-ui/src/main/webapp/tests/unit/routes/vertex/tasks-test.js
@@ -40,9 +40,15 @@ test('Basic creation test', function(assert) {
 });
 
 test('setupController test', function(assert) {
-  assert.expect(1);
+  assert.expect(2);
 
   let route = this.subject({
+    modelFor: function (type) {
+      assert.equal(type, 'vertex');
+      return Ember.Object.create({
+        entityID: 'vertex_123'
+      });
+    },
     startCrumbBubble: function () {
       assert.ok(true);
     }


Mime
View raw message