tez-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ss...@apache.org
Subject tez git commit: Revert "TEZ-3625. Dag.getVertex should obtain a readlock. (sseth)"
Date Fri, 24 Feb 2017 20:52:53 GMT
Repository: tez
Updated Branches:
  refs/heads/branch-0.8 d38642a25 -> 44d620abf


Revert "TEZ-3625. Dag.getVertex should obtain a readlock. (sseth)"

This reverts commit d38642a251859e53b6696ddca50bd856b8ebb900.


Project: http://git-wip-us.apache.org/repos/asf/tez/repo
Commit: http://git-wip-us.apache.org/repos/asf/tez/commit/44d620ab
Tree: http://git-wip-us.apache.org/repos/asf/tez/tree/44d620ab
Diff: http://git-wip-us.apache.org/repos/asf/tez/diff/44d620ab

Branch: refs/heads/branch-0.8
Commit: 44d620abf8adadf21d2226cbfa33a10e2c66773e
Parents: d38642a
Author: Siddharth Seth <sseth@apache.org>
Authored: Fri Feb 24 12:52:47 2017 -0800
Committer: Siddharth Seth <sseth@apache.org>
Committed: Fri Feb 24 12:52:47 2017 -0800

----------------------------------------------------------------------
 CHANGES.txt                                                   | 1 -
 .../src/main/java/org/apache/tez/dag/app/DAGAppMaster.java    | 1 -
 .../main/java/org/apache/tez/dag/app/dag/impl/DAGImpl.java    | 7 +------
 3 files changed, 1 insertion(+), 8 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/tez/blob/44d620ab/CHANGES.txt
----------------------------------------------------------------------
diff --git a/CHANGES.txt b/CHANGES.txt
index 85581ce..f399f39 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -7,7 +7,6 @@ INCOMPATIBLE CHANGES
 
 ALL CHANGES:
 
-  TEZ-3625. Dag.getVertex should obtain a readlock.
   TEZ-3624. Split multiple calls on the same line in TaskCommunicatorContextImpl.
   TEZ-3550. Provide access to sessionId/dagId via DagClient.
   TEZ-3609. Improve ATSv15 performance for DAG entities read calls.

http://git-wip-us.apache.org/repos/asf/tez/blob/44d620ab/tez-dag/src/main/java/org/apache/tez/dag/app/DAGAppMaster.java
----------------------------------------------------------------------
diff --git a/tez-dag/src/main/java/org/apache/tez/dag/app/DAGAppMaster.java b/tez-dag/src/main/java/org/apache/tez/dag/app/DAGAppMaster.java
index 0e4b29b..7ad6405 100644
--- a/tez-dag/src/main/java/org/apache/tez/dag/app/DAGAppMaster.java
+++ b/tez-dag/src/main/java/org/apache/tez/dag/app/DAGAppMaster.java
@@ -2546,7 +2546,6 @@ public class DAGAppMaster extends AbstractService {
 
     // Send out an event to inform components that a new DAG has been submitted.
     // Information about this DAG is available via the context.
-    // This event may be processed after DAG_INIT, but will be processed before DAG_START
     sendEvent(new DAGAppMasterEvent(DAGAppMasterEventType.NEW_DAG_SUBMITTED));
     // create a job event for job initialization
     DAGEvent initDagEvent = new DAGEvent(currentDAG.getID(), DAGEventType.DAG_INIT);

http://git-wip-us.apache.org/repos/asf/tez/blob/44d620ab/tez-dag/src/main/java/org/apache/tez/dag/app/dag/impl/DAGImpl.java
----------------------------------------------------------------------
diff --git a/tez-dag/src/main/java/org/apache/tez/dag/app/dag/impl/DAGImpl.java b/tez-dag/src/main/java/org/apache/tez/dag/app/dag/impl/DAGImpl.java
index 569f9f3..fd6d446 100644
--- a/tez-dag/src/main/java/org/apache/tez/dag/app/dag/impl/DAGImpl.java
+++ b/tez-dag/src/main/java/org/apache/tez/dag/app/dag/impl/DAGImpl.java
@@ -1810,12 +1810,7 @@ public class DAGImpl implements org.apache.tez.dag.app.dag.DAG,
 
   @Override
   public Vertex getVertex(String vertexName) {
-    this.readLock.lock();
-    try {
-      return vertexMap.get(vertexName);
-    } finally {
-      this.readLock.unlock();
-    }
+    return vertexMap.get(vertexName);
   }
 
   private void mayBeConstructFinalFullCounters() {


Mime
View raw message