tez-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From s...@apache.org
Subject tez git commit: TEZ-3398. Tez UI: Bread crumb link to Application from Application details dag/configuration tab is broken (sree)
Date Thu, 04 Aug 2016 09:25:00 GMT
Repository: tez
Updated Branches:
  refs/heads/branch-0.8 ad954d796 -> 890fe1070


TEZ-3398. Tez UI: Bread crumb link to Application from Application details dag/configuration
tab is broken (sree)


Project: http://git-wip-us.apache.org/repos/asf/tez/repo
Commit: http://git-wip-us.apache.org/repos/asf/tez/commit/890fe107
Tree: http://git-wip-us.apache.org/repos/asf/tez/tree/890fe107
Diff: http://git-wip-us.apache.org/repos/asf/tez/diff/890fe107

Branch: refs/heads/branch-0.8
Commit: 890fe1070ce2345a7b4d7538abe3cf14ff9566c5
Parents: ad954d7
Author: Sreenath Somarajapuram <sree@apache.org>
Authored: Thu Aug 4 14:54:04 2016 +0530
Committer: Sreenath Somarajapuram <sree@apache.org>
Committed: Thu Aug 4 14:54:04 2016 +0530

----------------------------------------------------------------------
 CHANGES.txt                                     |  1 +
 tez-ui2/src/main/webapp/app/controllers/app.js  |  2 +-
 .../webapp/tests/unit/controllers/app-test.js   | 22 +++++++++++++++++++-
 3 files changed, 23 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/tez/blob/890fe107/CHANGES.txt
----------------------------------------------------------------------
diff --git a/CHANGES.txt b/CHANGES.txt
index 32fca17..e9d6218 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -20,6 +20,7 @@ ALL CHANGES:
   TEZ-3337. Do not log empty fields of TaskAttemptFinishedEvent to avoid confusion.
   TEZ-1248. Reduce slow-start should special case 1 reducer runs.
   TEZ-3370. Tez UI: Display the log link as N/A if the app does not provide a log link
+  TEZ-3398. Tez UI: Bread crumb link to Application from Application details dag/configuration
tab is broken
 
 Release 0.8.4: 2016-07-08
 

http://git-wip-us.apache.org/repos/asf/tez/blob/890fe107/tez-ui2/src/main/webapp/app/controllers/app.js
----------------------------------------------------------------------
diff --git a/tez-ui2/src/main/webapp/app/controllers/app.js b/tez-ui2/src/main/webapp/app/controllers/app.js
index f379e80..809625e 100644
--- a/tez-ui2/src/main/webapp/app/controllers/app.js
+++ b/tez-ui2/src/main/webapp/app/controllers/app.js
@@ -27,7 +27,7 @@ export default ParentController.extend({
     return [{
       text: `Application [ ${name} ]`,
       routeName: "app.index",
-      model: this.get("model.entityID")
+      model: this.get("model.appID")
     }];
   }),
 

http://git-wip-us.apache.org/repos/asf/tez/blob/890fe107/tez-ui2/src/main/webapp/tests/unit/controllers/app-test.js
----------------------------------------------------------------------
diff --git a/tez-ui2/src/main/webapp/tests/unit/controllers/app-test.js b/tez-ui2/src/main/webapp/tests/unit/controllers/app-test.js
index 2fc7276..f6ed543 100644
--- a/tez-ui2/src/main/webapp/tests/unit/controllers/app-test.js
+++ b/tez-ui2/src/main/webapp/tests/unit/controllers/app-test.js
@@ -20,7 +20,7 @@ import Ember from 'ember';
 
 import { moduleFor, test } from 'ember-qunit';
 
-moduleFor('controller:dag', 'Unit | Controller | dag', {
+moduleFor('controller:app', 'Unit | Controller | app', {
   // Specify the other units that are required for this test.
   // needs: ['controller:foo']
 });
@@ -35,3 +35,23 @@ test('Basic creation test', function(assert) {
   assert.ok(controller.breadcrumbs);
   assert.ok(controller.tabs);
 });
+
+test('breadcrumbs test', function(assert) {
+  let appID = 123,
+  appName = "app123",
+  controller = this.subject({
+    send: Ember.K,
+    initVisibleColumns: Ember.K,
+    model: {
+      app: {
+        name: appName
+      },
+      appID: appID
+    }
+  });
+
+  assert.equal(controller.get("breadcrumbs.length"), 1);
+  assert.equal(controller.get("breadcrumbs.0.text"), `Application [ ${appName} ]`);
+  assert.equal(controller.get("breadcrumbs.0.routeName"), 'app.index');
+  assert.equal(controller.get("breadcrumbs.0.model"), appID);
+});


Mime
View raw message