tez-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From s...@apache.org
Subject tez git commit: TEZ-3398. Tez UI: Bread crumb link to Application from Application details dag/configuration tab is broken (sree)
Date Thu, 04 Aug 2016 03:51:15 GMT
Repository: tez
Updated Branches:
  refs/heads/master 3546a411a -> b8ff9417e


TEZ-3398. Tez UI: Bread crumb link to Application from Application details dag/configuration
tab is broken (sree)


Project: http://git-wip-us.apache.org/repos/asf/tez/repo
Commit: http://git-wip-us.apache.org/repos/asf/tez/commit/b8ff9417
Tree: http://git-wip-us.apache.org/repos/asf/tez/tree/b8ff9417
Diff: http://git-wip-us.apache.org/repos/asf/tez/diff/b8ff9417

Branch: refs/heads/master
Commit: b8ff9417eda8885bdfb19cbe4a3d758ee9a23ec1
Parents: 3546a41
Author: Sreenath Somarajapuram <sree@apache.org>
Authored: Thu Aug 4 09:20:42 2016 +0530
Committer: Sreenath Somarajapuram <sree@apache.org>
Committed: Thu Aug 4 09:20:42 2016 +0530

----------------------------------------------------------------------
 CHANGES.txt                                     |  1 +
 tez-ui/src/main/webapp/app/controllers/app.js   |  2 +-
 .../webapp/tests/unit/controllers/app-test.js   | 20 ++++++++++++++++++++
 3 files changed, 22 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/tez/blob/b8ff9417/CHANGES.txt
----------------------------------------------------------------------
diff --git a/CHANGES.txt b/CHANGES.txt
index 1df4d09..389ab5f 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -87,6 +87,7 @@ ALL CHANGES:
   TEZ-3329. Tez ATS data is incomplete for a vertex which fails or gets killed before initialization
   TEZ-3333. Tez UI: Handle cases where Vertex/Task/Task Attempt data is missing
   TEZ-3370. Tez UI: Display the log link as N/A if the app does not provide a log link
+  TEZ-3398. Tez UI: Bread crumb link to Application from Application details dag/configuration
tab is broken
 
 Release 0.8.5: Unreleased
 

http://git-wip-us.apache.org/repos/asf/tez/blob/b8ff9417/tez-ui/src/main/webapp/app/controllers/app.js
----------------------------------------------------------------------
diff --git a/tez-ui/src/main/webapp/app/controllers/app.js b/tez-ui/src/main/webapp/app/controllers/app.js
index f379e80..809625e 100644
--- a/tez-ui/src/main/webapp/app/controllers/app.js
+++ b/tez-ui/src/main/webapp/app/controllers/app.js
@@ -27,7 +27,7 @@ export default ParentController.extend({
     return [{
       text: `Application [ ${name} ]`,
       routeName: "app.index",
-      model: this.get("model.entityID")
+      model: this.get("model.appID")
     }];
   }),
 

http://git-wip-us.apache.org/repos/asf/tez/blob/b8ff9417/tez-ui/src/main/webapp/tests/unit/controllers/app-test.js
----------------------------------------------------------------------
diff --git a/tez-ui/src/main/webapp/tests/unit/controllers/app-test.js b/tez-ui/src/main/webapp/tests/unit/controllers/app-test.js
index f969d7e..318b665 100644
--- a/tez-ui/src/main/webapp/tests/unit/controllers/app-test.js
+++ b/tez-ui/src/main/webapp/tests/unit/controllers/app-test.js
@@ -37,3 +37,23 @@ test('Basic creation test', function(assert) {
 
   assert.equal(controller.tabs.length, 3);
 });
+
+test('breadcrumbs test', function(assert) {
+  let appID = 123,
+  appName = "app123",
+  controller = this.subject({
+    send: Ember.K,
+    initVisibleColumns: Ember.K,
+    model: {
+      app: {
+        name: appName
+      },
+      appID: appID
+    }
+  });
+
+  assert.equal(controller.get("breadcrumbs.length"), 1);
+  assert.equal(controller.get("breadcrumbs.0.text"), `Application [ ${appName} ]`);
+  assert.equal(controller.get("breadcrumbs.0.routeName"), 'app.index');
+  assert.equal(controller.get("breadcrumbs.0.model"), appID);
+});


Mime
View raw message