tez-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jeag...@apache.org
Subject tez git commit: TEZ-2967. Vertex start time should be that of first task start time in UI (jeagles)
Date Mon, 21 Mar 2016 15:40:11 GMT
Repository: tez
Updated Branches:
  refs/heads/master dacd0191b -> 19280cfc6


TEZ-2967. Vertex start time should be that of first task start time in UI (jeagles)


Project: http://git-wip-us.apache.org/repos/asf/tez/repo
Commit: http://git-wip-us.apache.org/repos/asf/tez/commit/19280cfc
Tree: http://git-wip-us.apache.org/repos/asf/tez/tree/19280cfc
Diff: http://git-wip-us.apache.org/repos/asf/tez/diff/19280cfc

Branch: refs/heads/master
Commit: 19280cfc656e19e686806bd3ab16a0a7f8610380
Parents: dacd019
Author: Jonathan Eagles <jeagles@yahoo-inc.com>
Authored: Mon Mar 21 10:39:09 2016 -0500
Committer: Jonathan Eagles <jeagles@yahoo-inc.com>
Committed: Mon Mar 21 10:39:17 2016 -0500

----------------------------------------------------------------------
 CHANGES.txt                                           | 2 ++
 tez-ui/src/main/webapp/app/scripts/models/dag.js      | 4 ++--
 tez-ui/src/main/webapp/app/templates/vertex/index.hbs | 4 ++++
 3 files changed, 8 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/tez/blob/19280cfc/CHANGES.txt
----------------------------------------------------------------------
diff --git a/CHANGES.txt b/CHANGES.txt
index f7dd9d9..fa60657 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -7,6 +7,7 @@ INCOMPATIBLE CHANGES
   TEZ-3029. Add an onError method to service plugin contexts.
 
 ALL CHANGES:
+  TEZ-2967. Vertex start time should be that of first task start time in UI
   TEZ-3175. Add tez client submit host
   TEZ-3166. Fix a few cases where counters aren't fully updated and sent for failed tasks.
   TEZ-2958. Recovered TA, whose commit cannot be recovered, should move to killed state
@@ -407,6 +408,7 @@ INCOMPATIBLE CHANGES
   TEZ-2949. Allow duplicate dag names within session for Tez.
 
 ALL CHANGES:
+  TEZ-2967. Vertex start time should be that of first task start time in UI
   TEZ-3175. Add tez client submit host
   TEZ-3166. Fix a few cases where counters aren't fully updated and sent for failed tasks.
   TEZ-2958. Recovered TA, whose commit cannot be recovered, should move to killed state

http://git-wip-us.apache.org/repos/asf/tez/blob/19280cfc/tez-ui/src/main/webapp/app/scripts/models/dag.js
----------------------------------------------------------------------
diff --git a/tez-ui/src/main/webapp/app/scripts/models/dag.js b/tez-ui/src/main/webapp/app/scripts/models/dag.js
index 4f9bfa5..7a7ee78 100644
--- a/tez-ui/src/main/webapp/app/scripts/models/dag.js
+++ b/tez-ui/src/main/webapp/app/scripts/models/dag.js
@@ -194,8 +194,8 @@ App.Vertex = App.AbstractEntity.extend({
    * @return {Number} Duration in milliseconds.
    */
   duration: function () {
-    return App.Helpers.date.duration(this.get('startTime'), this.get('endTime'))
-  }.property('startTime', 'endTime'),
+    return App.Helpers.date.duration(this.get('firstTaskStartTime') || this.get('startTime'),
this.get('endTime'))
+  }.property('startTime', 'firstTaskStartTime', 'endTime'),
 
   /**
    * Each Tez vertex can perform arbitrary application specific computations

http://git-wip-us.apache.org/repos/asf/tez/blob/19280cfc/tez-ui/src/main/webapp/app/templates/vertex/index.hbs
----------------------------------------------------------------------
diff --git a/tez-ui/src/main/webapp/app/templates/vertex/index.hbs b/tez-ui/src/main/webapp/app/templates/vertex/index.hbs
index e72aa8e..96e82fc 100644
--- a/tez-ui/src/main/webapp/app/templates/vertex/index.hbs
+++ b/tez-ui/src/main/webapp/app/templates/vertex/index.hbs
@@ -89,7 +89,11 @@
         </tr>
         <tr>
           <td>{{t 'common.time.duration'}}</td>
+          {{#if hasFirstTaskStarted}}
+          <td>{{formatDuration firstTaskStartTime endTime}}</td>
+          {{else}}
           <td>{{formatDuration startTime endTime}}</td>
+          {{/if}}
         </tr>
         {{#if hasFirstTaskStarted}}
           <tr>


Mime
View raw message