tez-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jeag...@apache.org
Subject tez git commit: TEZ-2967. Vertex start time should be that of first task start time in UI (jeagles)
Date Mon, 21 Mar 2016 15:42:56 GMT
Repository: tez
Updated Branches:
  refs/heads/branch-0.7 6823ab548 -> e49658159


TEZ-2967. Vertex start time should be that of first task start time in UI (jeagles)

(cherry picked from commit 19280cfc656e19e686806bd3ab16a0a7f8610380)


Project: http://git-wip-us.apache.org/repos/asf/tez/repo
Commit: http://git-wip-us.apache.org/repos/asf/tez/commit/e4965815
Tree: http://git-wip-us.apache.org/repos/asf/tez/tree/e4965815
Diff: http://git-wip-us.apache.org/repos/asf/tez/diff/e4965815

Branch: refs/heads/branch-0.7
Commit: e49658159378e14ecbf7ddd635e05563476eb4b1
Parents: 6823ab5
Author: Jonathan Eagles <jeagles@yahoo-inc.com>
Authored: Mon Mar 21 10:39:09 2016 -0500
Committer: Jonathan Eagles <jeagles@yahoo-inc.com>
Committed: Mon Mar 21 10:42:16 2016 -0500

----------------------------------------------------------------------
 CHANGES.txt                                           | 1 +
 tez-ui/src/main/webapp/app/scripts/models/dag.js      | 4 ++--
 tez-ui/src/main/webapp/app/templates/vertex/index.hbs | 4 ++++
 3 files changed, 7 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/tez/blob/e4965815/CHANGES.txt
----------------------------------------------------------------------
diff --git a/CHANGES.txt b/CHANGES.txt
index 7723197..6dee7e6 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -9,6 +9,7 @@ INCOMPATIBLE CHANGES
   TEZ-2972. Avoid task rescheduling when a node turns unhealthy
 
 ALL CHANGES:
+  TEZ-2967. Vertex start time should be that of first task start time in UI
   TEZ-3175. Add tez client submit host
   TEZ-3166. Fix a few cases where counters aren't fully updated and sent for failed tasks.
Only adds tests.
   TEZ-2958. Recovered TA, whose commit cannot be recovered, should move to killed state

http://git-wip-us.apache.org/repos/asf/tez/blob/e4965815/tez-ui/src/main/webapp/app/scripts/models/dag.js
----------------------------------------------------------------------
diff --git a/tez-ui/src/main/webapp/app/scripts/models/dag.js b/tez-ui/src/main/webapp/app/scripts/models/dag.js
index 3ea76d2..e6eae6d 100644
--- a/tez-ui/src/main/webapp/app/scripts/models/dag.js
+++ b/tez-ui/src/main/webapp/app/scripts/models/dag.js
@@ -192,8 +192,8 @@ App.Vertex = App.AbstractEntity.extend({
    * @return {Number} Duration in milliseconds.
    */
   duration: function () {
-    return App.Helpers.date.duration(this.get('startTime'), this.get('endTime'))
-  }.property('startTime', 'endTime'),
+    return App.Helpers.date.duration(this.get('firstTaskStartTime') || this.get('startTime'),
this.get('endTime'))
+  }.property('startTime', 'firstTaskStartTime', 'endTime'),
 
   /**
    * Each Tez vertex can perform arbitrary application specific computations

http://git-wip-us.apache.org/repos/asf/tez/blob/e4965815/tez-ui/src/main/webapp/app/templates/vertex/index.hbs
----------------------------------------------------------------------
diff --git a/tez-ui/src/main/webapp/app/templates/vertex/index.hbs b/tez-ui/src/main/webapp/app/templates/vertex/index.hbs
index e72aa8e..96e82fc 100644
--- a/tez-ui/src/main/webapp/app/templates/vertex/index.hbs
+++ b/tez-ui/src/main/webapp/app/templates/vertex/index.hbs
@@ -89,7 +89,11 @@
         </tr>
         <tr>
           <td>{{t 'common.time.duration'}}</td>
+          {{#if hasFirstTaskStarted}}
+          <td>{{formatDuration firstTaskStartTime endTime}}</td>
+          {{else}}
           <td>{{formatDuration startTime endTime}}</td>
+          {{/if}}
         </tr>
         {{#if hasFirstTaskStarted}}
           <tr>


Mime
View raw message