tez-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ss...@apache.org
Subject tez git commit: TEZ-2896. Fix thread names used during Input/Output initialization. (sseth) (cherry picked from commit 25f0247ee77bb483e52298bbf839eb15bc314454)
Date Thu, 15 Oct 2015 18:45:35 GMT
Repository: tez
Updated Branches:
  refs/heads/branch-0.7 4ac6af6ed -> 0ae7e5994


TEZ-2896. Fix thread names used during Input/Output initialization. (sseth)
(cherry picked from commit 25f0247ee77bb483e52298bbf839eb15bc314454)

Conflicts:
	CHANGES.txt


Project: http://git-wip-us.apache.org/repos/asf/tez/repo
Commit: http://git-wip-us.apache.org/repos/asf/tez/commit/0ae7e599
Tree: http://git-wip-us.apache.org/repos/asf/tez/tree/0ae7e599
Diff: http://git-wip-us.apache.org/repos/asf/tez/diff/0ae7e599

Branch: refs/heads/branch-0.7
Commit: 0ae7e5994b7d3f53d1a9e5b4d6f2a7780fdebea8
Parents: 4ac6af6
Author: Siddharth Seth <sseth@apache.org>
Authored: Thu Oct 15 11:44:00 2015 -0700
Committer: Siddharth Seth <sseth@apache.org>
Committed: Thu Oct 15 11:45:26 2015 -0700

----------------------------------------------------------------------
 CHANGES.txt                                                 | 1 +
 .../apache/tez/runtime/LogicalIOProcessorRuntimeTask.java   | 9 +++------
 .../common/shuffle/impl/SimpleFetchedInputAllocator.java    | 2 +-
 3 files changed, 5 insertions(+), 7 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/tez/blob/0ae7e599/CHANGES.txt
----------------------------------------------------------------------
diff --git a/CHANGES.txt b/CHANGES.txt
index 7650f96..b9d775d 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -6,6 +6,7 @@ Release 0.7.1: Unreleased
 INCOMPATIBLE CHANGES
 
 ALL CHANGES
+  TEZ-2896. Fix thread names used during Input/Output initialization.
   TEZ-2866. Tez UI: Newly added columns wont be displayed by default in tables
   TEZ-2885. Remove counter logs from AMWebController.
   TEZ-2887. Tez build failure due to missing dependency in pom files.

http://git-wip-us.apache.org/repos/asf/tez/blob/0ae7e599/tez-runtime-internals/src/main/java/org/apache/tez/runtime/LogicalIOProcessorRuntimeTask.java
----------------------------------------------------------------------
diff --git a/tez-runtime-internals/src/main/java/org/apache/tez/runtime/LogicalIOProcessorRuntimeTask.java
b/tez-runtime-internals/src/main/java/org/apache/tez/runtime/LogicalIOProcessorRuntimeTask.java
index c61bb4e..dde3548 100644
--- a/tez-runtime-internals/src/main/java/org/apache/tez/runtime/LogicalIOProcessorRuntimeTask.java
+++ b/tez-runtime-internals/src/main/java/org/apache/tez/runtime/LogicalIOProcessorRuntimeTask.java
@@ -186,7 +186,7 @@ public class LogicalIOProcessorRuntimeTask extends RuntimeTask {
     this.initializerExecutor = Executors.newFixedThreadPool(
         numInitializers,
         new ThreadFactoryBuilder().setDaemon(true)
-            .setNameFormat("Initializer %d").build());
+            .setNameFormat("I/O Setup %d").build());
     this.initializerCompletionService = new ExecutorCompletionService<Void>(
         this.initializerExecutor);
     this.groupInputSpecs = taskSpec.getGroupInputs();
@@ -406,7 +406,7 @@ public class LogicalIOProcessorRuntimeTask extends RuntimeTask {
     protected Void callInternal() throws Exception {
       String oldThreadName = Thread.currentThread().getName();
       try {
-        Thread.currentThread().setName(oldThreadName + "{" + inputSpec.getSourceVertexName()
+ "}");
+        Thread.currentThread().setName(oldThreadName + " Initialize: {" + inputSpec.getSourceVertexName()
+ "}");
         return _callInternal();
       } finally {
         Thread.currentThread().setName(oldThreadName);
@@ -414,7 +414,6 @@ public class LogicalIOProcessorRuntimeTask extends RuntimeTask {
     }
 
     protected Void _callInternal() throws Exception {
-
       if (LOG.isDebugEnabled()) {
         LOG.debug("Initializing Input using InputSpec: " + inputSpec);
       }
@@ -458,7 +457,6 @@ public class LogicalIOProcessorRuntimeTask extends RuntimeTask {
     }
 
     protected Void _callInternal() throws Exception {
-      Thread.currentThread().setName("InitializerStart {" + srcVertexName + "}");
       if (LOG.isDebugEnabled()) {
         LOG.debug("Starting Input with src edge: " + srcVertexName);
       }
@@ -483,7 +481,7 @@ public class LogicalIOProcessorRuntimeTask extends RuntimeTask {
     protected Void callInternal() throws Exception {
       String oldThreadName = Thread.currentThread().getName();
       try {
-        Thread.currentThread().setName(oldThreadName + "{" + outputSpec.getDestinationVertexName()
+ "}");
+        Thread.currentThread().setName(oldThreadName + " Initialize: {" + outputSpec.getDestinationVertexName()
+ "}");
         return _callInternal();
       } finally {
         Thread.currentThread().setName(oldThreadName);
@@ -491,7 +489,6 @@ public class LogicalIOProcessorRuntimeTask extends RuntimeTask {
     }
 
     protected Void _callInternal() throws Exception {
-      Thread.currentThread().setName("Initializer {" + outputSpec.getDestinationVertexName()
+ "}");
       if (LOG.isDebugEnabled()) {
         LOG.debug("Initializing Output using OutputSpec: " + outputSpec);
       }

http://git-wip-us.apache.org/repos/asf/tez/blob/0ae7e599/tez-runtime-library/src/main/java/org/apache/tez/runtime/library/common/shuffle/impl/SimpleFetchedInputAllocator.java
----------------------------------------------------------------------
diff --git a/tez-runtime-library/src/main/java/org/apache/tez/runtime/library/common/shuffle/impl/SimpleFetchedInputAllocator.java
b/tez-runtime-library/src/main/java/org/apache/tez/runtime/library/common/shuffle/impl/SimpleFetchedInputAllocator.java
index 604d213..68c4781 100644
--- a/tez-runtime-library/src/main/java/org/apache/tez/runtime/library/common/shuffle/impl/SimpleFetchedInputAllocator.java
+++ b/tez-runtime-library/src/main/java/org/apache/tez/runtime/library/common/shuffle/impl/SimpleFetchedInputAllocator.java
@@ -111,7 +111,7 @@ public class SimpleFetchedInputAllocator implements FetchedInputAllocator,
 
     LOG.info(srcNameTrimmed + ": "
         + "RequestedMemory=" + memReq
-        + ", AssignedMemorty=" + this.memoryLimit
+        + ", AssignedMemory=" + this.memoryLimit
         + ", maxSingleShuffleLimit=" + this.maxSingleShuffleLimit
     );
 


Mime
View raw message