tez-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ss...@apache.org
Subject tez git commit: TEZ-2896. Fix thread names used during Input/Output initialization. (sseth)
Date Thu, 15 Oct 2015 18:44:21 GMT
Repository: tez
Updated Branches:
  refs/heads/master b421e4f61 -> 25f0247ee


TEZ-2896. Fix thread names used during Input/Output initialization. (sseth)


Project: http://git-wip-us.apache.org/repos/asf/tez/repo
Commit: http://git-wip-us.apache.org/repos/asf/tez/commit/25f0247e
Tree: http://git-wip-us.apache.org/repos/asf/tez/tree/25f0247e
Diff: http://git-wip-us.apache.org/repos/asf/tez/diff/25f0247e

Branch: refs/heads/master
Commit: 25f0247ee77bb483e52298bbf839eb15bc314454
Parents: b421e4f
Author: Siddharth Seth <sseth@apache.org>
Authored: Thu Oct 15 11:44:00 2015 -0700
Committer: Siddharth Seth <sseth@apache.org>
Committed: Thu Oct 15 11:44:00 2015 -0700

----------------------------------------------------------------------
 CHANGES.txt                                                 | 2 ++
 .../apache/tez/runtime/LogicalIOProcessorRuntimeTask.java   | 9 +++------
 .../common/shuffle/impl/SimpleFetchedInputAllocator.java    | 2 +-
 3 files changed, 6 insertions(+), 7 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/tez/blob/25f0247e/CHANGES.txt
----------------------------------------------------------------------
diff --git a/CHANGES.txt b/CHANGES.txt
index b833f81..7d90402 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -6,6 +6,7 @@ Release 0.8.2: Unreleased
 INCOMPATIBLE CHANGES
 
 ALL CHANGES:
+  TEZ-2896. Fix thread names used during Input/Output initialization.
   TEZ-2866. Tez UI: Newly added columns wont be displayed by default in tables
   TEZ-2887. Tez build failure due to missing dependency in pom files.
   TEZ-1692. Reduce code duplication between TezMapredSplitsGrouper and TezMapreduceSplitsGrouper.
@@ -214,6 +215,7 @@ Release 0.7.1: Unreleased
 INCOMPATIBLE CHANGES
 
 ALL CHANGES
+  TEZ-2896. Fix thread names used during Input/Output initialization.
   TEZ-2866. Tez UI: Newly added columns wont be displayed by default in tables
   TEZ-2885. Remove counter logs from AMWebController.
   TEZ-2887. Tez build failure due to missing dependency in pom files.

http://git-wip-us.apache.org/repos/asf/tez/blob/25f0247e/tez-runtime-internals/src/main/java/org/apache/tez/runtime/LogicalIOProcessorRuntimeTask.java
----------------------------------------------------------------------
diff --git a/tez-runtime-internals/src/main/java/org/apache/tez/runtime/LogicalIOProcessorRuntimeTask.java
b/tez-runtime-internals/src/main/java/org/apache/tez/runtime/LogicalIOProcessorRuntimeTask.java
index 5db96c5..4b00c97 100644
--- a/tez-runtime-internals/src/main/java/org/apache/tez/runtime/LogicalIOProcessorRuntimeTask.java
+++ b/tez-runtime-internals/src/main/java/org/apache/tez/runtime/LogicalIOProcessorRuntimeTask.java
@@ -190,7 +190,7 @@ public class LogicalIOProcessorRuntimeTask extends RuntimeTask {
     this.initializerExecutor = Executors.newFixedThreadPool(
         numInitializers,
         new ThreadFactoryBuilder().setDaemon(true)
-            .setNameFormat("Initializer %d").build());
+            .setNameFormat("I/O Setup %d").build());
     this.initializerCompletionService = new ExecutorCompletionService<Void>(
         this.initializerExecutor);
     this.groupInputSpecs = taskSpec.getGroupInputs();
@@ -410,7 +410,7 @@ public class LogicalIOProcessorRuntimeTask extends RuntimeTask {
     protected Void callInternal() throws Exception {
       String oldThreadName = Thread.currentThread().getName();
       try {
-        Thread.currentThread().setName(oldThreadName + "{" + inputSpec.getSourceVertexName()
+ "}");
+        Thread.currentThread().setName(oldThreadName + " Initialize: {" + inputSpec.getSourceVertexName()
+ "}");
         return _callInternal();
       } finally {
         Thread.currentThread().setName(oldThreadName);
@@ -418,7 +418,6 @@ public class LogicalIOProcessorRuntimeTask extends RuntimeTask {
     }
 
     protected Void _callInternal() throws Exception {
-
       if (LOG.isDebugEnabled()) {
         LOG.debug("Initializing Input using InputSpec: " + inputSpec);
       }
@@ -464,7 +463,6 @@ public class LogicalIOProcessorRuntimeTask extends RuntimeTask {
     }
 
     protected Void _callInternal() throws Exception {
-      Thread.currentThread().setName("InitializerStart {" + srcVertexName + "}");
       if (LOG.isDebugEnabled()) {
         LOG.debug("Starting Input with src edge: " + srcVertexName);
       }
@@ -489,7 +487,7 @@ public class LogicalIOProcessorRuntimeTask extends RuntimeTask {
     protected Void callInternal() throws Exception {
       String oldThreadName = Thread.currentThread().getName();
       try {
-        Thread.currentThread().setName(oldThreadName + "{" + outputSpec.getDestinationVertexName()
+ "}");
+        Thread.currentThread().setName(oldThreadName + " Initialize: {" + outputSpec.getDestinationVertexName()
+ "}");
         return _callInternal();
       } finally {
         Thread.currentThread().setName(oldThreadName);
@@ -497,7 +495,6 @@ public class LogicalIOProcessorRuntimeTask extends RuntimeTask {
     }
 
     protected Void _callInternal() throws Exception {
-      Thread.currentThread().setName("Initializer {" + outputSpec.getDestinationVertexName()
+ "}");
       if (LOG.isDebugEnabled()) {
         LOG.debug("Initializing Output using OutputSpec: " + outputSpec);
       }

http://git-wip-us.apache.org/repos/asf/tez/blob/25f0247e/tez-runtime-library/src/main/java/org/apache/tez/runtime/library/common/shuffle/impl/SimpleFetchedInputAllocator.java
----------------------------------------------------------------------
diff --git a/tez-runtime-library/src/main/java/org/apache/tez/runtime/library/common/shuffle/impl/SimpleFetchedInputAllocator.java
b/tez-runtime-library/src/main/java/org/apache/tez/runtime/library/common/shuffle/impl/SimpleFetchedInputAllocator.java
index 604d213..68c4781 100644
--- a/tez-runtime-library/src/main/java/org/apache/tez/runtime/library/common/shuffle/impl/SimpleFetchedInputAllocator.java
+++ b/tez-runtime-library/src/main/java/org/apache/tez/runtime/library/common/shuffle/impl/SimpleFetchedInputAllocator.java
@@ -111,7 +111,7 @@ public class SimpleFetchedInputAllocator implements FetchedInputAllocator,
 
     LOG.info(srcNameTrimmed + ": "
         + "RequestedMemory=" + memReq
-        + ", AssignedMemorty=" + this.memoryLimit
+        + ", AssignedMemory=" + this.memoryLimit
         + ", maxSingleShuffleLimit=" + this.maxSingleShuffleLimit
     );
 


Mime
View raw message