Return-Path: X-Original-To: apmail-tez-commits-archive@minotaur.apache.org Delivered-To: apmail-tez-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3FDD518475 for ; Sat, 22 Aug 2015 07:26:01 +0000 (UTC) Received: (qmail 99388 invoked by uid 500); 22 Aug 2015 07:26:01 -0000 Delivered-To: apmail-tez-commits-archive@tez.apache.org Received: (qmail 99339 invoked by uid 500); 22 Aug 2015 07:26:01 -0000 Mailing-List: contact commits-help@tez.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tez.apache.org Delivered-To: mailing list commits@tez.apache.org Received: (qmail 99208 invoked by uid 99); 22 Aug 2015 07:26:01 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 22 Aug 2015 07:26:01 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 081D5DFD9E; Sat, 22 Aug 2015 07:26:01 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: sseth@apache.org To: commits@tez.apache.org Date: Sat, 22 Aug 2015 07:26:14 -0000 Message-Id: <8c13e603ec184d17a3eca6e1b7ea6d2f@git.apache.org> In-Reply-To: <2a5d73e46f33459bb1e1ac71d0f152f9@git.apache.org> References: <2a5d73e46f33459bb1e1ac71d0f152f9@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: [15/50] [abbrv] tez git commit: TEZ-2471. NPE in LogicalIOProcessorRuntimeTask while printing thread info. (sseth) TEZ-2471. NPE in LogicalIOProcessorRuntimeTask while printing thread info. (sseth) Project: http://git-wip-us.apache.org/repos/asf/tez/repo Commit: http://git-wip-us.apache.org/repos/asf/tez/commit/971e0957 Tree: http://git-wip-us.apache.org/repos/asf/tez/tree/971e0957 Diff: http://git-wip-us.apache.org/repos/asf/tez/diff/971e0957 Branch: refs/heads/master Commit: 971e0957a1302e20fe241b4aeac278dc87111257 Parents: 9e6bd7c Author: Siddharth Seth Authored: Fri May 22 11:03:11 2015 -0700 Committer: Siddharth Seth Committed: Fri Aug 21 18:13:55 2015 -0700 ---------------------------------------------------------------------- TEZ-2003-CHANGES.txt | 1 + .../org/apache/tez/runtime/LogicalIOProcessorRuntimeTask.java | 5 ++++- 2 files changed, 5 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/tez/blob/971e0957/TEZ-2003-CHANGES.txt ---------------------------------------------------------------------- diff --git a/TEZ-2003-CHANGES.txt b/TEZ-2003-CHANGES.txt index ca3383c..d651960 100644 --- a/TEZ-2003-CHANGES.txt +++ b/TEZ-2003-CHANGES.txt @@ -27,5 +27,6 @@ ALL CHANGES: TEZ-2434. Allow tasks to be killed in the Runtime. TEZ-2443. TaskRunner2 should call abort, NPEs while cleaning up tasks. TEZ-2465. Retrun the status of a kill request in TaskRunner2. + TEZ-2471. NPE in LogicalIOProcessorRuntimeTask while printing thread info. INCOMPATIBLE CHANGES: http://git-wip-us.apache.org/repos/asf/tez/blob/971e0957/tez-runtime-internals/src/main/java/org/apache/tez/runtime/LogicalIOProcessorRuntimeTask.java ---------------------------------------------------------------------- diff --git a/tez-runtime-internals/src/main/java/org/apache/tez/runtime/LogicalIOProcessorRuntimeTask.java b/tez-runtime-internals/src/main/java/org/apache/tez/runtime/LogicalIOProcessorRuntimeTask.java index de08e56..449fa0f 100644 --- a/tez-runtime-internals/src/main/java/org/apache/tez/runtime/LogicalIOProcessorRuntimeTask.java +++ b/tez-runtime-internals/src/main/java/org/apache/tez/runtime/LogicalIOProcessorRuntimeTask.java @@ -936,7 +936,10 @@ public class LogicalIOProcessorRuntimeTask extends RuntimeTask { long[] threadIds = threadMXBean.getAllThreadIds(); for (Long id : threadIds) { ThreadInfo threadInfo = threadMXBean.getThreadInfo(id); - LOG.info("ThreadId : " + id + ", name=" + threadInfo.getThreadName()); + // The thread could have been shutdown before we read info about it. + if (threadInfo != null) { + LOG.debug("ThreadId : " + id + ", name=" + threadInfo.getThreadName()); + } } }