tez-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ss...@apache.org
Subject [03/37] tez git commit: TEZ-2298. Avoid logging full exception trace in TaskRunner when it's not the main error reason and is ignored. (sseth)
Date Tue, 28 Apr 2015 20:40:44 GMT
TEZ-2298. Avoid logging full exception trace in TaskRunner when it's not
the main error reason and is ignored. (sseth)


Project: http://git-wip-us.apache.org/repos/asf/tez/repo
Commit: http://git-wip-us.apache.org/repos/asf/tez/commit/bbbebb80
Tree: http://git-wip-us.apache.org/repos/asf/tez/tree/bbbebb80
Diff: http://git-wip-us.apache.org/repos/asf/tez/diff/bbbebb80

Branch: refs/heads/TEZ-2003
Commit: bbbebb8091fc135f629741e7a8748c986c209271
Parents: 778c1f5
Author: Siddharth Seth <sseth@apache.org>
Authored: Fri Apr 24 09:42:57 2015 -0700
Committer: Siddharth Seth <sseth@apache.org>
Committed: Fri Apr 24 09:42:57 2015 -0700

----------------------------------------------------------------------
 CHANGES.txt                                               |  1 +
 .../java/org/apache/tez/runtime/task/TezTaskRunner.java   | 10 ++++++++--
 2 files changed, 9 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/tez/blob/bbbebb80/CHANGES.txt
----------------------------------------------------------------------
diff --git a/CHANGES.txt b/CHANGES.txt
index afb458a..e21d178 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -9,6 +9,7 @@ INCOMPATIBLE CHANGES
   TEZ-1993. Implement a pluggable InputSizeEstimator for grouping fairly
 
 ALL CHANGES:
+  TEZ-2298. Avoid logging full exception trace in TaskRunner when it's not the main error
reason and is ignored.
   TEZ-2248. VertexImpl/DAGImpl.checkForCompletion have too many termination cause checks
   TEZ-2341. TestMockDAGAppMaster.testBasicCounters fails on windows
   TEZ-2352. Move getTaskStatistics into the RuntimeTask class.

http://git-wip-us.apache.org/repos/asf/tez/blob/bbbebb80/tez-runtime-internals/src/main/java/org/apache/tez/runtime/task/TezTaskRunner.java
----------------------------------------------------------------------
diff --git a/tez-runtime-internals/src/main/java/org/apache/tez/runtime/task/TezTaskRunner.java
b/tez-runtime-internals/src/main/java/org/apache/tez/runtime/task/TezTaskRunner.java
index 766b5c3..de83889 100644
--- a/tez-runtime-internals/src/main/java/org/apache/tez/runtime/task/TezTaskRunner.java
+++ b/tez-runtime-internals/src/main/java/org/apache/tez/runtime/task/TezTaskRunner.java
@@ -209,7 +209,10 @@ public class TezTaskRunner implements TezUmbilical, ErrorReporter {
                   // Ignored since another cause is already known
                   LOG.info(
                       "Ignoring the following exception since a previous exception is already
registered",
-                      ignored);
+                      ignored.getClass().getName());
+                  if (LOG.isTraceEnabled()) {
+                    LOG.trace("Ignored exception is", ignored);
+                  }
                 }
                 throw (FSError) cause;
               } else if (cause instanceof Error) {
@@ -229,7 +232,10 @@ public class TezTaskRunner implements TezUmbilical, ErrorReporter {
                   // Ignored since another cause is already known
                   LOG.info(
                       "Ignoring the following exception since a previous exception is already
registered",
-                      ignored);
+                      ignored.getClass().getName());
+                  if (LOG.isTraceEnabled()) {
+                    LOG.trace("Ignored exception is", ignored);
+                  }
                 }
                 if (cause instanceof IOException) {
                   throw (IOException) cause;


Mime
View raw message