tez-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From prak...@apache.org
Subject tez git commit: TEZ-2084. Tez UI: Stacktrace format info is lost in diagnostics (pramachandran)
Date Wed, 29 Apr 2015 17:37:59 GMT
Repository: tez
Updated Branches:
  refs/heads/master 9ba4b1b18 -> c76698ea3


TEZ-2084. Tez UI: Stacktrace format info is lost in diagnostics (pramachandran)


Project: http://git-wip-us.apache.org/repos/asf/tez/repo
Commit: http://git-wip-us.apache.org/repos/asf/tez/commit/c76698ea
Tree: http://git-wip-us.apache.org/repos/asf/tez/tree/c76698ea
Diff: http://git-wip-us.apache.org/repos/asf/tez/diff/c76698ea

Branch: refs/heads/master
Commit: c76698ea337bd8e95e31a5b953db72b56b614dd7
Parents: 9ba4b1b
Author: Prakash Ramachandran <pramachandran@hortonworks.com>
Authored: Wed Apr 29 23:07:23 2015 +0530
Committer: Prakash Ramachandran <pramachandran@hortonworks.com>
Committed: Wed Apr 29 23:07:23 2015 +0530

----------------------------------------------------------------------
 CHANGES.txt                                                    | 1 +
 tez-ui/src/main/webapp/app/scripts/helpers/handlebarHelpers.js | 6 ++++--
 tez-ui/src/main/webapp/app/styles/main.less                    | 2 +-
 3 files changed, 6 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/tez/blob/c76698ea/CHANGES.txt
----------------------------------------------------------------------
diff --git a/CHANGES.txt b/CHANGES.txt
index e248286..b8b5fd0 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -9,6 +9,7 @@ INCOMPATIBLE CHANGES
   TEZ-1993. Implement a pluggable InputSizeEstimator for grouping fairly
 
 ALL CHANGES:
+  TEZ-2084. Tez UI: Stacktrace format info is lost in diagnostics
   TEZ-2374. Fix build break against hadoop-2.2 due to TEZ-2325.
   TEZ-2314. Tez task attempt failures due to bad event serialization
   TEZ-2368. Make a dag identifier available in Context classes.

http://git-wip-us.apache.org/repos/asf/tez/blob/c76698ea/tez-ui/src/main/webapp/app/scripts/helpers/handlebarHelpers.js
----------------------------------------------------------------------
diff --git a/tez-ui/src/main/webapp/app/scripts/helpers/handlebarHelpers.js b/tez-ui/src/main/webapp/app/scripts/helpers/handlebarHelpers.js
index 5fe475f..f42a504 100644
--- a/tez-ui/src/main/webapp/app/scripts/helpers/handlebarHelpers.js
+++ b/tez-ui/src/main/webapp/app/scripts/helpers/handlebarHelpers.js
@@ -67,9 +67,11 @@ function replaceAll(str, str1, str2, ignore)
 
 //TODO: needs better indendation.
 Em.Handlebars.helper('formatDiagnostics', function(diagnostics) {
-  var x = replaceAll(diagnostics, '[', '<div class="indent"><i>&nbsp;</i>');
-  x = replaceAll(x, '],', '</div><i>&nbsp;</i>');
+  var x = replaceAll(diagnostics, '[', '<div class="log-indent"><i>&nbsp;</i>');
+  x = replaceAll(x, '],', '</div>');
   x = replaceAll(x, ']', '</div>');
+  x = replaceAll(x, '\n', '<br />');
+  x = replaceAll(x, '\t', '<span class="log-indent" /></span>');
   return new Handlebars.SafeString(x);
 });
 

http://git-wip-us.apache.org/repos/asf/tez/blob/c76698ea/tez-ui/src/main/webapp/app/styles/main.less
----------------------------------------------------------------------
diff --git a/tez-ui/src/main/webapp/app/styles/main.less b/tez-ui/src/main/webapp/app/styles/main.less
index 8204b19..ba8f375 100644
--- a/tez-ui/src/main/webapp/app/styles/main.less
+++ b/tez-ui/src/main/webapp/app/styles/main.less
@@ -434,7 +434,7 @@ body, html {
   margin-left: 5px;
 }
 
-div.indent {
+.log-indent {
   margin: 0px 0px 0px 20px;
   i {
     .fa;


Mime
View raw message