tez-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ss...@apache.org
Subject tez git commit: TEZ-1899. Fix findbugs warnings in tez-common module. (sseth)
Date Wed, 07 Jan 2015 03:35:25 GMT
Repository: tez
Updated Branches:
  refs/heads/master 393e40b8d -> 0030309bb


TEZ-1899. Fix findbugs warnings in tez-common module. (sseth)


Project: http://git-wip-us.apache.org/repos/asf/tez/repo
Commit: http://git-wip-us.apache.org/repos/asf/tez/commit/0030309b
Tree: http://git-wip-us.apache.org/repos/asf/tez/tree/0030309b
Diff: http://git-wip-us.apache.org/repos/asf/tez/diff/0030309b

Branch: refs/heads/master
Commit: 0030309bba4172aeba38f23ed5acdd14a79fe4b2
Parents: 393e40b
Author: Siddharth Seth <sseth@apache.org>
Authored: Tue Jan 6 19:35:10 2015 -0800
Committer: Siddharth Seth <sseth@apache.org>
Committed: Tue Jan 6 19:35:10 2015 -0800

----------------------------------------------------------------------
 CHANGES.txt                                         |  1 +
 pom.xml                                             |  8 ++++----
 tez-common/findbugs-exclude.xml                     |  6 ++++++
 .../org/apache/tez/common/TezUtilsInternal.java     |  4 +++-
 .../findbugs-exclude.xml                            | 16 ++++++++++++++++
 .../findbugs-exclude.xml                            | 16 ++++++++++++++++
 .../tez-yarn-timeline-history/findbugs-exclude.xml  | 16 ++++++++++++++++
 tez-runtime-library/findbugs-exclude.xml            | 16 ++++++++++++++++
 tez-tests/findbugs-exclude.xml                      | 16 ++++++++++++++++
 tez-ui/findbugs-exclude.xml                         | 16 ++++++++++++++++
 10 files changed, 110 insertions(+), 5 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/tez/blob/0030309b/CHANGES.txt
----------------------------------------------------------------------
diff --git a/CHANGES.txt b/CHANGES.txt
index b9cd1d1..99f09f4 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -7,6 +7,7 @@ Release 0.7.0: Unreleased
 INCOMPATIBLE CHANGES
 
 ALL CHANGES:
+  TEZ-1899. Fix findbugs warnings in tez-common module.
   TEZ-1898. Fix findbugs warnings in tez-api module.
   TEZ-1906. Fix findbugs warnings in tez-yarn-timeline-history-with-acls.
   TEZ-1767. Enable RLE in reducer side merge codepath.

http://git-wip-us.apache.org/repos/asf/tez/blob/0030309b/pom.xml
----------------------------------------------------------------------
diff --git a/pom.xml b/pom.xml
index bd03cdd..beac010 100644
--- a/pom.xml
+++ b/pom.xml
@@ -850,7 +850,7 @@
         <groupId>org.codehaus.mojo</groupId>
         <artifactId>findbugs-maven-plugin</artifactId>
         <configuration>
-          <excludeFilterFile>findbugs-exclude.xml</excludeFilterFile>
+          <excludeFilterFile>${basedir}/findbugs-exclude.xml</excludeFilterFile>
         </configuration>
       </plugin>
    </plugins>
@@ -955,7 +955,7 @@
               </execution>
             </executions>
             <configuration>
-              <excludeFilterFile>findbugs-exclude.xml</excludeFilterFile>
+              <excludeFilterFile>${basedir}/findbugs-exclude.xml</excludeFilterFile>
             </configuration>
           </plugin>
         </plugins>
@@ -971,7 +971,7 @@
                 <format>html</format>
               </formats>
               <canGenerate>true</canGenerate>
-              <excludeFilterFile>findbugs-exclude.xml</excludeFilterFile>
+              <excludeFilterFile>${basedir}/findbugs-exclude.xml</excludeFilterFile>
             </configuration>
           </plugin>
         </plugins>
@@ -1081,7 +1081,7 @@
         <groupId>org.codehaus.mojo</groupId>
         <artifactId>findbugs-maven-plugin</artifactId>
         <configuration>
-          <excludeFilterFile>findbugs-exclude.xml</excludeFilterFile>
+          <excludeFilterFile>${basedir}/findbugs-exclude.xml</excludeFilterFile>
         </configuration>
       </plugin>
     </plugins>

http://git-wip-us.apache.org/repos/asf/tez/blob/0030309b/tez-common/findbugs-exclude.xml
----------------------------------------------------------------------
diff --git a/tez-common/findbugs-exclude.xml b/tez-common/findbugs-exclude.xml
index 5b11308..2950e65 100644
--- a/tez-common/findbugs-exclude.xml
+++ b/tez-common/findbugs-exclude.xml
@@ -13,4 +13,10 @@
 -->
 <FindBugsFilter>
 
+  <Match>
+    <Class name="org.apache.tez.common.AsyncDispatcher"/>
+    <Method name="dispatch"/>
+    <Bug pattern="DM_EXIT"/>
+  </Match>
+
 </FindBugsFilter>

http://git-wip-us.apache.org/repos/asf/tez/blob/0030309b/tez-common/src/main/java/org/apache/tez/common/TezUtilsInternal.java
----------------------------------------------------------------------
diff --git a/tez-common/src/main/java/org/apache/tez/common/TezUtilsInternal.java b/tez-common/src/main/java/org/apache/tez/common/TezUtilsInternal.java
index 30401cb..8d54ead 100644
--- a/tez-common/src/main/java/org/apache/tez/common/TezUtilsInternal.java
+++ b/tez-common/src/main/java/org/apache/tez/common/TezUtilsInternal.java
@@ -22,6 +22,7 @@ import java.io.File;
 import java.io.FileInputStream;
 import java.io.FileNotFoundException;
 import java.io.IOException;
+import java.nio.charset.Charset;
 import java.util.BitSet;
 import java.util.List;
 import java.util.Map;
@@ -230,7 +231,8 @@ public class TezUtilsInternal {
         Credentials credentials =
             DagTypeConverters.convertByteStringToCredentials(dagPlan.getCredentialsBinary());
         TextFormat.printField(entry.getKey(),
-            ByteString.copyFrom(TezCommonUtils.getCredentialsInfo(credentials,"dag").getBytes()),
sb);
+            ByteString.copyFrom(TezCommonUtils.getCredentialsInfo(credentials,"dag").getBytes(
+                Charset.forName("UTF-8"))), sb);
       }
     }
     return sb.toString();

http://git-wip-us.apache.org/repos/asf/tez/blob/0030309b/tez-plugins/tez-mbeans-resource-calculator/findbugs-exclude.xml
----------------------------------------------------------------------
diff --git a/tez-plugins/tez-mbeans-resource-calculator/findbugs-exclude.xml b/tez-plugins/tez-mbeans-resource-calculator/findbugs-exclude.xml
new file mode 100644
index 0000000..5b11308
--- /dev/null
+++ b/tez-plugins/tez-mbeans-resource-calculator/findbugs-exclude.xml
@@ -0,0 +1,16 @@
+<!--
+  Licensed under the Apache License, Version 2.0 (the "License");
+  you may not use this file except in compliance with the License.
+  You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+  Unless required by applicable law or agreed to in writing, software
+  distributed under the License is distributed on an "AS IS" BASIS,
+  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  See the License for the specific language governing permissions and
+  limitations under the License. See accompanying LICENSE file.
+-->
+<FindBugsFilter>
+
+</FindBugsFilter>

http://git-wip-us.apache.org/repos/asf/tez/blob/0030309b/tez-plugins/tez-yarn-timeline-history-with-acls/findbugs-exclude.xml
----------------------------------------------------------------------
diff --git a/tez-plugins/tez-yarn-timeline-history-with-acls/findbugs-exclude.xml b/tez-plugins/tez-yarn-timeline-history-with-acls/findbugs-exclude.xml
new file mode 100644
index 0000000..5b11308
--- /dev/null
+++ b/tez-plugins/tez-yarn-timeline-history-with-acls/findbugs-exclude.xml
@@ -0,0 +1,16 @@
+<!--
+  Licensed under the Apache License, Version 2.0 (the "License");
+  you may not use this file except in compliance with the License.
+  You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+  Unless required by applicable law or agreed to in writing, software
+  distributed under the License is distributed on an "AS IS" BASIS,
+  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  See the License for the specific language governing permissions and
+  limitations under the License. See accompanying LICENSE file.
+-->
+<FindBugsFilter>
+
+</FindBugsFilter>

http://git-wip-us.apache.org/repos/asf/tez/blob/0030309b/tez-plugins/tez-yarn-timeline-history/findbugs-exclude.xml
----------------------------------------------------------------------
diff --git a/tez-plugins/tez-yarn-timeline-history/findbugs-exclude.xml b/tez-plugins/tez-yarn-timeline-history/findbugs-exclude.xml
new file mode 100644
index 0000000..5b11308
--- /dev/null
+++ b/tez-plugins/tez-yarn-timeline-history/findbugs-exclude.xml
@@ -0,0 +1,16 @@
+<!--
+  Licensed under the Apache License, Version 2.0 (the "License");
+  you may not use this file except in compliance with the License.
+  You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+  Unless required by applicable law or agreed to in writing, software
+  distributed under the License is distributed on an "AS IS" BASIS,
+  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  See the License for the specific language governing permissions and
+  limitations under the License. See accompanying LICENSE file.
+-->
+<FindBugsFilter>
+
+</FindBugsFilter>

http://git-wip-us.apache.org/repos/asf/tez/blob/0030309b/tez-runtime-library/findbugs-exclude.xml
----------------------------------------------------------------------
diff --git a/tez-runtime-library/findbugs-exclude.xml b/tez-runtime-library/findbugs-exclude.xml
new file mode 100644
index 0000000..5b11308
--- /dev/null
+++ b/tez-runtime-library/findbugs-exclude.xml
@@ -0,0 +1,16 @@
+<!--
+  Licensed under the Apache License, Version 2.0 (the "License");
+  you may not use this file except in compliance with the License.
+  You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+  Unless required by applicable law or agreed to in writing, software
+  distributed under the License is distributed on an "AS IS" BASIS,
+  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  See the License for the specific language governing permissions and
+  limitations under the License. See accompanying LICENSE file.
+-->
+<FindBugsFilter>
+
+</FindBugsFilter>

http://git-wip-us.apache.org/repos/asf/tez/blob/0030309b/tez-tests/findbugs-exclude.xml
----------------------------------------------------------------------
diff --git a/tez-tests/findbugs-exclude.xml b/tez-tests/findbugs-exclude.xml
new file mode 100644
index 0000000..5b11308
--- /dev/null
+++ b/tez-tests/findbugs-exclude.xml
@@ -0,0 +1,16 @@
+<!--
+  Licensed under the Apache License, Version 2.0 (the "License");
+  you may not use this file except in compliance with the License.
+  You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+  Unless required by applicable law or agreed to in writing, software
+  distributed under the License is distributed on an "AS IS" BASIS,
+  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  See the License for the specific language governing permissions and
+  limitations under the License. See accompanying LICENSE file.
+-->
+<FindBugsFilter>
+
+</FindBugsFilter>

http://git-wip-us.apache.org/repos/asf/tez/blob/0030309b/tez-ui/findbugs-exclude.xml
----------------------------------------------------------------------
diff --git a/tez-ui/findbugs-exclude.xml b/tez-ui/findbugs-exclude.xml
new file mode 100644
index 0000000..5b11308
--- /dev/null
+++ b/tez-ui/findbugs-exclude.xml
@@ -0,0 +1,16 @@
+<!--
+  Licensed under the Apache License, Version 2.0 (the "License");
+  you may not use this file except in compliance with the License.
+  You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+  Unless required by applicable law or agreed to in writing, software
+  distributed under the License is distributed on an "AS IS" BASIS,
+  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  See the License for the specific language governing permissions and
+  limitations under the License. See accompanying LICENSE file.
+-->
+<FindBugsFilter>
+
+</FindBugsFilter>


Mime
View raw message