Mailing-List: contact websh-dev-help@tcl.apache.org; run by ezmlm
Precedence: bulk
To: websh-dev@tcl.apache.org
Subject: Re: remaining fixme's
References: <87hent23q5.fsf@dedasys.com> <877koo6v7z.fsf@dedasys.com>
From: davidw@dedasys.com (David N. Welton)
Date: 12 Mar 2002 12:45:06 +0100
In-Reply-To: <877koo6v7z.fsf@dedasys.com>
Message-ID: <87r8mqvwl9.fsf@dedasys.com>
Lines: 44
User-Agent: Gnus/5.0808 (Gnus v5.8.8) Emacs/20.7
MIME-Version: 1.0
Content-Type: text/plain; charset=
Content-Transfer-Encoding: quoted-printable


interpool.c:502:	/* fixme: in threaded mode, this is a bit too rude maybe */

How shall we make it more polite?  I don't really understand the
problem - destroyPool might stomp on someone else's resources?

log.c:832:    /* fixme: destroyLogPlugIn - have to assume that all channels=
 are closed */

Let's just send something to stderr, then.

logtochannel.c:162:    /* fixme: should we do this on a channel ? */
    /* Tcl_Seek(logToChannelData->channel, 0, SEEK_END); */

       The driver must provide implementations for all  functions
       except  blockModeProc, seekProc, setOptionProc, getOption=AD
       Proc, and close2Proc, which  may  be  specified  as  NULL.

So, I would say that we shouldn't be doing it, just in case...

logutl.c:432:	/* fixme: race condition under WIN NT */

Don't know about NT, although if you describe the problem, I can take
a stab at it.

mod_websh.c:176:    /* fixme: is this correct? (reset the locks) */

static void *merge_websh_config(APPOOL * p, void *basev, void *overridesv)
{
    /* fixme: is this correct? (reset the locks) */
    ((websh_server_conf *) overridesv)->mainInterpLock =3D NULL;
    ((websh_server_conf *) overridesv)->webshPoolLock =3D NULL;
    return overridesv;
}

It seems like an odd place to be doing this...  This should be done as
an initilization step, no?  I mean, there aren't seperate locks for
overridden server configurations.

--=20
David N. Welton
   Consulting: http://www.dedasys.com/
     Personal: http://www.dedasys.com/davidw/
Free Software: http://www.dedasys.com/freesoftware/
   Apache Tcl: http://tcl.apache.org/

---------------------------------------------------------------------
To unsubscribe, e-mail: websh-dev-unsubscribe@tcl.apache.org
For additional commands, e-mail: websh-dev-help@tcl.apache.org