Mailing-List: contact websh-dev-help@tcl.apache.org; run by ezmlm
Precedence: bulk
To: websh-dev@tcl.apache.org
Subject: Re: remaining fixme's
References: <87hent23q5.fsf@dedasys.com>
From: davidw@dedasys.com (David N. Welton)
Date: 07 Mar 2002 20:20:16 +0100
In-Reply-To: <87hent23q5.fsf@dedasys.com>
Message-ID: <877koo6v7z.fsf@dedasys.com>
Lines: 25
User-Agent: Gnus/5.0808 (Gnus v5.8.8) Emacs/20.7
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii

davidw@dedasys.com (David N. Welton) writes:

> interpool.c:468:    /* fixme: is this really called once, by a single thread, and we don't do
> 
>     /* fixme: is this really called once, by a single thread, and we don't do
>        any locking in here ?? */
> 
>     /* check immediately to see if we have already been called.  */
> 
> I will do this by adding a 'called' variable to websh_server_conf if
> there are no objections.

Or how about just a static variable?  If it doesn't have a threading
problem, that seems simple enough.

I don't see how it could be called more than once, though, except by
multiple threads.  In which case, we should be doing the lock,
shouldn't we.

-- 
David N. Welton
   Consulting: http://www.dedasys.com/
     Personal: http://www.dedasys.com/davidw/
Free Software: http://www.dedasys.com/freesoftware/
   Apache Tcl: http://tcl.apache.org/

---------------------------------------------------------------------
To unsubscribe, e-mail: websh-dev-unsubscribe@tcl.apache.org
For additional commands, e-mail: websh-dev-help@tcl.apache.org