tcl-websh-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dav...@dedasys.com (David N. Welton)
Subject Re: interpool.c: initPool
Date Thu, 28 Mar 2002 08:59:59 GMT
Ronnie Brunner <ronnie@netcetera.ch> writes:

> we're still talking about 

>    interpool.c:485   int initPool(websh_server_conf * conf)

> > We should also return 0 to let the next layer up know that we
> > weren't successful.

> I would actually also remove the "called" stuff...


> Summing it up, I'd dump the whole if clause:

Done.

> In addition, we should find out what to do if we ever return 0 in initPool.

    if (!initPool(conf)) {
	ap_log_error(APLOG_MARK, APLOG_ERR, NULL, s,
		     "Could not init interp pool\n");
	return;
    }

Nothing explicit, but things are at this point broken enough that they
will error out further on down the line.  The only other thing we
could do is exit...

-- 
David N. Welton
   Consulting: http://www.dedasys.com/
     Personal: http://www.dedasys.com/davidw/
Free Software: http://www.dedasys.com/freesoftware/
   Apache Tcl: http://tcl.apache.org/

---------------------------------------------------------------------
To unsubscribe, e-mail: websh-dev-unsubscribe@tcl.apache.org
For additional commands, e-mail: websh-dev-help@tcl.apache.org


Mime
View raw message