tcl-websh-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dav...@dedasys.com (David N. Welton)
Subject remaining fixme's
Date Wed, 06 Mar 2002 14:03:14 GMT

formdata.c:64:    /* fixme: we don't set the channel options back. maybe we should. */
formdata.c:217:    /* fixme: we don't set the channel options back. maybe we should. */
formdata.c:267:    /* fixme: only read content_length bytes ... */

The above are to be documented and fixed later.

interpool.c:331:	      /* fixme: make expiring message easy to understand (add
interpool.c:354:		/* fixme: make expiring message easy to understand
interpool.c:401:	    /* fixme: log to apache *somehow* */
interpool.c:446:	    /* fixme: add interp id to log */

These would be much easier to accomplish with straight ap_ commands.

interpool.c:468:    /* fixme: is this really called once, by a single thread, and we don't
do

    /* fixme: is this really called once, by a single thread, and we don't do
       any locking in here ?? */

    /* check immediately to see if we have already been called.  */

I will do this by adding a 'called' variable to websh_server_conf if
there are no objections.

interpool.c:477:	/* fixme: in threaded mode, this is a bit too rude maybe */

I looked at my notes and I'm not sure about this one.

interpool.c:640:		    /* fixme: put id in log (for easier debugging) */

Another one where the ap_log_error function would be best.

log.c:832:    /* fixme: destroyLogPlugIn - have to assume that all channels are closed */

What do channels have to do with it?  

mod_websh.c:176:    /* fixme: is this correct? (reset the locks) */

IIRC, we were undecided on this.

paramlist.c:35:    /* fixme-later: fixed allocation */

To be done later, as indicated.

request.c:66:    /*fixme: needed? Simon will deal with this. */

Simon claimed this one, although I will axe it myself by tommorow, if
needs be - it's pretty easy.

request.c:424:    /* fixme: should I check for for TMP_MAX filenames per app ?

Fixme later.

response_ap.c:88:		    /* fixme

This one is moderately complex, and I would like a test case that
illustrates the expected behaviour, if possible.

response_ap.c:122:	/* fixme: ap 2.0 API might change this call ? */

Find out how to send headers in apache 2.0....

-- 
David N. Welton
   Consulting: http://www.dedasys.com/
     Personal: http://www.dedasys.com/davidw/
Free Software: http://www.dedasys.com/freesoftware/
   Apache Tcl: http://tcl.apache.org/

---------------------------------------------------------------------
To unsubscribe, e-mail: websh-dev-unsubscribe@tcl.apache.org
For additional commands, e-mail: websh-dev-help@tcl.apache.org


Mime
View raw message