tcl-websh-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dav...@dedasys.com (David N. Welton)
Subject Re: remaining fixme's
Date Wed, 27 Mar 2002 10:52:05 GMT
Ronnie Brunner <ronnie@netcetera.ch> writes:

> Long story short conclusion: I'd dump the whole lock.

Done.

> >From this issue we could conclude that the remaining fixme

>      /* fixme: in threaded mode, this is a bit too rude maybe */

> can savely be ignored as well (since we're called only once and before
> any request is handled)

Ok, removed.

> BTW: we should not even enter this if clause anyway -> we have a
> serious problem, if this ever gets called. Suggested fix:

>     if (conf->mainInterp != NULL || conf->webshPool != NULL) {
>         /* we have to cleanup */
> #ifndef APACHE2
> 	ap_log_printf(conf->server, "initPool: mainInterp or webshPool not NULL\n");
> #else /* APACHE2 */
>         ap_log_error(APLOG_MARK, APLOG_NOERRNO | APLOG_ERR, 0, conf->server,
> 	     "initPool: mainInterp or webshPool not NULL\n");
> #endif /* APACHE2 */
>         destroyPool(conf);
>     }

> Objections?

We should also return 0 to let the next layer up know that we weren't
successful.

-- 
David N. Welton
   Consulting: http://www.dedasys.com/
     Personal: http://www.dedasys.com/davidw/
Free Software: http://www.dedasys.com/freesoftware/
   Apache Tcl: http://tcl.apache.org/

---------------------------------------------------------------------
To unsubscribe, e-mail: websh-dev-unsubscribe@tcl.apache.org
For additional commands, e-mail: websh-dev-help@tcl.apache.org


Mime
View raw message