taverna-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sagar15795 <...@git.apache.org>
Subject [GitHub] incubator-taverna-mobile pull request #73: Fix: Improvements in UsageActivit...
Date Mon, 21 May 2018 07:18:09 GMT
Github user sagar15795 commented on a diff in the pull request:

    https://github.com/apache/incubator-taverna-mobile/pull/73#discussion_r189511113
  
    --- Diff: app/src/main/res/layout/activity_usage.xml ---
    @@ -33,16 +33,19 @@
             <LinearLayout
                 android:layout_width="match_parent"
                 android:layout_height="match_parent"
    -            android:orientation="vertical"
    -            android:padding="@dimen/usageLinearLayoutPadding">
    +            android:orientation="vertical">
     
                 <android.support.v7.widget.CardView
                     android:layout_width="match_parent"
    -                android:layout_height="match_parent"
    -                android:paddingBottom="@dimen/usageCardViewPaddingBotton">
    +                android:layout_height="wrap_content"
    +                android:paddingBottom="@dimen/usageCardViewPaddingBotton"
    --- End diff --
    
    change this also to `lowercase_underscore` conventions.


---

Mime
View raw message