taverna-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stian Soiland-Reyes (JIRA)" <j...@apache.org>
Subject [jira] [Created] (TAVERNA-1043) Java 9: ZIPFS folders no longer ends with /
Date Wed, 18 Apr 2018 13:36:00 GMT
Stian Soiland-Reyes created TAVERNA-1043:
--------------------------------------------

             Summary: Java 9: ZIPFS folders no longer ends with /
                 Key: TAVERNA-1043
                 URL: https://issues.apache.org/jira/browse/TAVERNA-1043
             Project: Apache Taverna
          Issue Type: Bug
          Components: Taverna Language
    Affects Versions: language 0.15.1
         Environment: JDK 9
            Reporter: Stian Soiland-Reyes
            Assignee: Stian Soiland-Reyes
             Fix For: language 0.16.0


Taverna Language on JDK9 fails with:

{code}
Failed tests: 
  TestZipFS.directoryOrFile:134
  TestManifest.populateFromBundle:93
  TestManifest.repopulateFromBundle:130
  TestManifestJSON.createBundle:206->checkManifestJson:290 expected:</folder[/]>
but was:</folder[]>
{code}

This seems mainly to be because this [JDK7 bug|https://stackoverflow.com/questions/16588321/java-7-zipfs-file-is-also-a-folder]
has finally been fixed. We used to test this in [TestZipFS](https://github.com/apache/incubator-taverna-language/blob/0.15.1-incubating/taverna-robundle/src/test/java/org/apache/taverna/robundle/fs/TestZipFS.java#L95)
- but this test now fails as the underlying ZipFS now in JDK9 finally correctly throws FileAlreadyExistsException
if attempting to make {{folder/}} after having made a file called just {{folder}}.

But this mean some of the other code (and their tests) maintaining the manifest.json gets
inconsistent folder paths with or without trailing /. We should keep the JSON serialization
and RO API with / at the end for consistency.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message