taverna-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Hiteshgautam01 <...@git.apache.org>
Subject [GitHub] incubator-taverna-mobile pull request #74: Fix: Replacing empty screens with...
Date Mon, 30 Apr 2018 08:08:18 GMT
Github user Hiteshgautam01 commented on a diff in the pull request:

    https://github.com/apache/incubator-taverna-mobile/pull/74#discussion_r184929070
  
    --- Diff: app/src/main/res/layout/fragment_dashboard.xml ---
    @@ -21,14 +21,35 @@
             android:layout_height="match_parent"
             android:background="@color/grey_background">
     
    -    <TextView
    -            android:id="@+id/tvNoWorkflow"
    +    <RelativeLayout
    +        android:layout_width="match_parent"
    +        android:layout_height="match_parent"
    +        android:layout_centerVertical="true"
    +        android:layout_centerHorizontal="true"
    +        android:visibility="gone"
    +        android:id="@+id/tvNoWorkflow"
    +        android:layout_marginBottom="@dimen/relative_layout_margin_bottom">
    +
    +        <ImageView
    +            android:id="@+id/workflow_icon"
    --- End diff --
    
    Hey @sagar15795 , id naming should not be in camel case according to https://github.com/ribot/android-guidelines/blob/master/project_and_code_guidelines.md#2321-id-naming


---

Mime
View raw message