From dev-return-4752-archive-asf-public=cust-asf.ponee.io@taverna.incubator.apache.org  Wed Mar 21 17:33:35 2018
Return-Path: <dev-return-4752-archive-asf-public=cust-asf.ponee.io@taverna.incubator.apache.org>
X-Original-To: archive-asf-public@cust-asf.ponee.io
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx-eu-01.ponee.io (Postfix) with SMTP id 2A8B818076D
	for <archive-asf-public@cust-asf.ponee.io>; Wed, 21 Mar 2018 17:33:33 +0100 (CET)
Received: (qmail 12522 invoked by uid 500); 21 Mar 2018 16:33:33 -0000
Mailing-List: contact dev-help@taverna.incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@taverna.incubator.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@taverna.incubator.apache.org>
List-Post: <mailto:dev@taverna.incubator.apache.org>
List-Id: <dev.taverna.incubator.apache.org>
Reply-To: dev@taverna.incubator.apache.org
Delivered-To: mailing list dev@taverna.incubator.apache.org
Received: (qmail 12368 invoked by uid 99); 21 Mar 2018 16:33:32 -0000
Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 21 Mar 2018 16:33:32 +0000
Received: from localhost (localhost [127.0.0.1])
	by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id EDD93C0144
	for <dev@taverna.apache.org>; Wed, 21 Mar 2018 16:33:31 +0000 (UTC)
X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org
X-Spam-Flag: NO
X-Spam-Score: -4.03
X-Spam-Level:
X-Spam-Status: No, score=-4.03 tagged_above=-999 required=6.31
	tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5,
	RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01,
	T_RP_MATCHES_RCVD=-0.01] autolearn=disabled
Received: from mx1-lw-us.apache.org ([10.40.0.8])
	by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024)
	with ESMTP id fMwW5nr0HNCo for <dev@taverna.apache.org>;
	Wed, 21 Mar 2018 16:33:31 +0000 (UTC)
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with SMTP id 8F20D5F5B1
	for <dev@taverna.incubator.apache.org>; Wed, 21 Mar 2018 16:33:30 +0000 (UTC)
Received: (qmail 12330 invoked by uid 99); 21 Mar 2018 16:33:30 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 21 Mar 2018 16:33:30 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 394A5F6729; Wed, 21 Mar 2018 16:33:29 +0000 (UTC)
From: sagar15795 <git@git.apache.org>
To: dev@taverna.incubator.apache.org
Reply-To: dev@taverna.incubator.apache.org
References: <git-pr-66-incubator-taverna-mobile@git.apache.org>
In-Reply-To: <git-pr-66-incubator-taverna-mobile@git.apache.org>
Subject: [GitHub] incubator-taverna-mobile pull request #66: Adds tutorial screens on first st...
Content-Type: text/plain
Message-Id: <20180321163329.394A5F6729@git1-us-west.apache.org>
Date: Wed, 21 Mar 2018 16:33:29 +0000 (UTC)

Github user sagar15795 commented on a diff in the pull request:

    https://github.com/apache/incubator-taverna-mobile/pull/66#discussion_r176150157
  
    --- Diff: app/src/main/res/layout/tutorial_slide4.xml ---
    @@ -0,0 +1,50 @@
    +<?xml version="1.0" encoding="utf-8"?>
    +<!--
    +   Licensed to the Apache Software Foundation (ASF) under one or more
    +   contributor license agreements.  See the NOTICE file distributed with
    +   this work for additional information regarding copyright ownership.
    +   The ASF licenses this file to You under the Apache License, Version 2.0
    +   (the "License"); you may not use this file except in compliance with
    +   the License.  You may obtain a copy of the License at
    +       http://www.apache.org/licenses/LICENSE-2.0
    +   Unless required by applicable law or agreed to in writing, software
    +   distributed under the License is distributed on an "AS IS" BASIS,
    +   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +   See the License for the specific language governing permissions and
    +   limitations under the License.
    +-->
    +
    +<RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"
    +    android:layout_width="match_parent"
    +    android:layout_height="match_parent"
    +    android:background="@color/bg_screen4">
    +
    +    <LinearLayout
    +        android:layout_width="wrap_content"
    +        android:layout_height="wrap_content"
    +        android:layout_centerInParent="true"
    +        android:gravity="center_horizontal"
    +        android:orientation="vertical">
    +
    +        <TextView
    +            android:layout_width="wrap_content"
    +            android:layout_height="wrap_content"
    +            android:text="@string/slide_4_title"
    +            android:textColor="@android:color/white"
    +            android:textSize="@dimen/slide_title"
    +            android:textStyle="bold" />
    +
    +        <TextView
    +            android:layout_width="wrap_content"
    +            android:layout_height="wrap_content"
    +            android:layout_marginTop="20dp"
    --- End diff --
    
    Move it to `dimens.xml`


---