taverna-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From saketkumar95 <...@git.apache.org>
Subject [GitHub] incubator-taverna-mobile pull request #68: Improved ImageZoom screen
Date Sat, 03 Mar 2018 07:10:00 GMT
GitHub user saketkumar95 opened a pull request:

    https://github.com/apache/incubator-taverna-mobile/pull/68

    Improved ImageZoom screen

    This PR improves the ImageZoom Screen. 
    
    - [x] Apply the `AndroidStyle.xml` style template to your code in Android Studio.
    
    - [x] Run the checks with `./gradlew check` to make sure you didn't break anything
    
    - [x] If you have multiple commits please combine them into one commit by squashing them.
    
    Here is the screenshot after changes : 
    ![screenshot_1520060327](https://user-images.githubusercontent.com/21558765/36931563-7bf9d28a-1ede-11e8-9529-32d6a778af22.png)
    
    @sagar15795 Please review! :)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/saketkumar95/incubator-taverna-mobile imageZoom

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-taverna-mobile/pull/68.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #68
    
----
commit d8a6a1d0aa5ba5cbe8430f0b8e373529186a6504
Author: saketkumar95 <saket.singh1410@...>
Date:   2018-03-03T06:56:36Z

    Improved ImageZoom screen

----


---

Mime
View raw message