taverna-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From therajanmaurya <...@git.apache.org>
Subject [GitHub] incubator-taverna-mobile pull request #71: Adding myExperiment logo on login...
Date Wed, 28 Mar 2018 07:45:30 GMT
Github user therajanmaurya commented on a diff in the pull request:

    https://github.com/apache/incubator-taverna-mobile/pull/71#discussion_r177662775
  
    --- Diff: app/src/main/res/values/dimens.xml ---
    @@ -71,15 +71,18 @@ limitations under the License.
         <dimen name="layout_padding">8dp</dimen>
         <dimen name="text_size">25sp</dimen>
         <dimen name="login_layout_padding">20dp</dimen>
    -    <dimen name="login_layout_marginTop">20dp</dimen>
    -    <dimen name="login_info_padding">10dp</dimen>
    +    <dimen name="login_layout_marginTop">15dp</dimen>
    +    <dimen name="login_info_padding">7dp</dimen>
    +    <dimen name="myExperimentLogoHeight">50dp</dimen>
    --- End diff --
    
    please rename the resource name with `my_experiment_logo_height`
    



---

Mime
View raw message