From dev-return-4606-archive-asf-public=cust-asf.ponee.io@taverna.incubator.apache.org Mon Feb 19 18:34:00 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 70E50180607 for ; Mon, 19 Feb 2018 18:33:59 +0100 (CET) Received: (qmail 54486 invoked by uid 500); 19 Feb 2018 17:33:58 -0000 Mailing-List: contact dev-help@taverna.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@taverna.incubator.apache.org Delivered-To: mailing list dev@taverna.incubator.apache.org Received: (qmail 54475 invoked by uid 99); 19 Feb 2018 17:33:57 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 19 Feb 2018 17:33:57 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 7E82D1A0921 for ; Mon, 19 Feb 2018 17:33:57 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -3.53 X-Spam-Level: X-Spam-Status: No, score=-3.53 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, KAM_NUMSUBJECT=0.5, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id iNlqkVpZaou3 for ; Mon, 19 Feb 2018 17:33:54 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id DAD295FAC9 for ; Mon, 19 Feb 2018 17:33:52 +0000 (UTC) Received: (qmail 52612 invoked by uid 99); 19 Feb 2018 17:33:51 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 19 Feb 2018 17:33:51 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 85F6EF2178; Mon, 19 Feb 2018 17:33:49 +0000 (UTC) From: therajanmaurya To: dev@taverna.incubator.apache.org Reply-To: dev@taverna.incubator.apache.org References: In-Reply-To: Subject: [GitHub] incubator-taverna-mobile pull request #56: Migration RxJava 1 -> RxJava2 Content-Type: text/plain Message-Id: <20180219173350.85F6EF2178@git1-us-west.apache.org> Date: Mon, 19 Feb 2018 17:33:49 +0000 (UTC) Github user therajanmaurya commented on a diff in the pull request: https://github.com/apache/incubator-taverna-mobile/pull/56#discussion_r169133509 --- Diff: app/src/main/java/org/apache/taverna/mobile/ui/favouriteworkflow/FavouriteWorkflowsPresenter.java --- @@ -84,19 +84,18 @@ public void onNext(List workflowList) { getMvpView().showEmptyWorkflow(); } } - }); - + })); } - public void attachSearchHandler(SearchView searchView) { + checkViewAttached(); RxSearch.fromSearchView(searchView) .debounce(300, TimeUnit.MILLISECONDS) .observeOn(AndroidSchedulers.mainThread()) - .subscribe(new Subscriber() { + .subscribeWith(new DisposableObserver() { @Override - public void onCompleted() { - + public void onNext(String s) { --- End diff -- Please change `s` with specific naming convention, I am sure It is search query so It's name can be `searchQuery` ---