taverna-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sagar15795 <...@git.apache.org>
Subject [GitHub] incubator-taverna-mobile pull request #61: Fix: Replace usage dialogue box w...
Date Tue, 27 Feb 2018 16:47:10 GMT
Github user sagar15795 commented on a diff in the pull request:

    https://github.com/apache/incubator-taverna-mobile/pull/61#discussion_r170987076
  
    --- Diff: app/src/main/java/org/apache/taverna/mobile/ui/usage/UsageActivity.java ---
    @@ -0,0 +1,62 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package org.apache.taverna.mobile.ui.usage;
    +
    +import android.support.v7.app.ActionBar;
    +import android.support.v7.app.AppCompatActivity;
    +import android.os.Bundle;
    +import android.support.v7.widget.Toolbar;
    +import android.view.MenuItem;
    +
    +import org.apache.taverna.mobile.R;
    +
    +import butterknife.BindView;
    +import butterknife.ButterKnife;
    +
    +public class UsageActivity extends AppCompatActivity {
    +
    +    @BindView(R.id.toolbar)
    +    Toolbar mToolbar;
    +
    +    @Override
    +    protected void onCreate(Bundle savedInstanceState) {
    +        super.onCreate(savedInstanceState);
    +        setContentView(R.layout.activity_usage);
    +        ButterKnife.bind(this);
    +
    +        setSupportActionBar(mToolbar);
    +        ActionBar actionbar = getSupportActionBar();
    +
    +        if (actionbar != null) {
    +            actionbar.setHomeButtonEnabled(true);
    +            actionbar.setDisplayHomeAsUpEnabled(true);
    +            actionbar.setTitle(R.string.title_usage);
    +        }
    +    }
    +
    +    @Override
    +    public boolean onOptionsItemSelected(MenuItem item) {
    +        switch (item.getItemId()) {
    +            case android.R.id.home:
    +                finish();
    --- End diff --
    
    It will be good if you will use [Google guidelines](https://developer.android.com/training/implementing-navigation/ancestral.html)
for up navigation.


---

Mime
View raw message