taverna-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From therajanmaurya <...@git.apache.org>
Subject [GitHub] incubator-taverna-mobile pull request #56: Migration RxJava 1 -> RxJava2
Date Mon, 19 Feb 2018 17:33:49 GMT
Github user therajanmaurya commented on a diff in the pull request:

    https://github.com/apache/incubator-taverna-mobile/pull/56#discussion_r169131194
  
    --- Diff: app/build.gradle ---
    @@ -82,11 +88,8 @@ dependencies {
         compile "com.jakewharton:butterknife:$rootProject.butterKnifeVersion"
         annotationProcessor "com.jakewharton:butterknife-compiler:$rootProject.butterKnifeVersion"
     
    -
    -    compile "io.reactivex:rxandroid:1.2.0"
    -// Because RxAndroid releases are few and far between, it is recommended you also
    -// explicitly depend on RxJava's latest version for bug fixes and new features.
    -    compile "io.reactivex:rxjava:1.1.5"
    +    compile "io.reactivex.rxjava2:rxjava:2.0.1"
    +    compile "io.reactivex.rxjava2:rxandroid:2.0.1"
    --- End diff --
    
    Please make `rxJavaVersion = 2.0.1` and `rxAndroidVersion = 2.0.1` in project build.gradle
and use here as we already using. 


---

Mime
View raw message