taverna-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stian Soiland-Reyes <st...@apache.org>
Subject Re: Outstanding pull requests
Date Thu, 07 Dec 2017 14:59:33 GMT
Ouch, no, we should not have null pointer exceptions.. :) 

Something in the ColourManager spring bean that needs to be manually wired up 
for the test? (Might use a mock object)

On Wed, 6 Dec 2017 14:03:54 +0100, Dmitry Repchevsky <redmitry@list.ru> wrote:
> https://github.com/apache/incubator-taverna-workbench/pulls
> 
> -------------------------------------------------------
> 
>   T E S T S
> -------------------------------------------------------
> Running 
> org.apache.taverna.workbench.ui.impl.configuration.colour.ColourManagerTest
> Tests run: 3, Failures: 0, Errors: 3, Skipped: 0, Time elapsed: 0.332 
> sec <<< FAILURE! - in 
> org.apache.taverna.workbench.ui.impl.configuration.colour.ColourManagerTest
> saveAsWrongArrayType(org.apache.taverna.workbench.ui.impl.configuration.colour.ColourManagerTest)

> Time elapsed: 0.237 sec  <<< ERROR!
> java.lang.NullPointerException
>      at 
> org.apache.taverna.workbench.ui.impl.configuration.colour.ColourManagerTest.setup(ColourManagerTest.java:45)
> 
> testConfigurableness(org.apache.taverna.workbench.ui.impl.configuration.colour.ColourManagerTest)

> Time elapsed: 0.001 sec  <<< ERROR!
> java.lang.NullPointerException
>      at 
> org.apache.taverna.workbench.ui.impl.configuration.colour.ColourManagerTest.setup(ColourManagerTest.java:45)
> 
> testGetPreferredColourEqualsWhite(org.apache.taverna.workbench.ui.impl.configuration.colour.ColourManagerTest)

> Time elapsed: 0.001 sec  <<< ERROR!
> java.lang.NullPointerException
>      at 
> org.apache.taverna.workbench.ui.impl.configuration.colour.ColourManagerTest.setup(ColourManagerTest.java:45)
> 
> Running 
> org.apache.taverna.workbench.ui.impl.configuration.ConfigurationManagerTest
> Tests run: 3, Failures: 0, Errors: 2, Skipped: 1, Time elapsed: 0 sec 
> <<< FAILURE! - in 
> org.apache.taverna.workbench.ui.impl.configuration.ConfigurationManagerTest
> saveColoursForDummyColourable(org.apache.taverna.workbench.ui.impl.configuration.ConfigurationManagerTest)

> Time elapsed: 0 sec  <<< ERROR!
> java.lang.NullPointerException
>      at 
> org.apache.taverna.workbench.ui.impl.configuration.ConfigurationManagerTest.setup(ConfigurationManagerTest.java:43)
> 
> createConfigManager(org.apache.taverna.workbench.ui.impl.configuration.ConfigurationManagerTest)

> Time elapsed: 0 sec  <<< ERROR!
> java.lang.NullPointerException
>      at 
> org.apache.taverna.workbench.ui.impl.configuration.ConfigurationManagerTest.setup(ConfigurationManagerTest.java:43)
> 
> 
> Results :
> 
> Tests in error:
>    ConfigurationManagerTest.setup:43 » NullPointer
>    ConfigurationManagerTest.setup:43 » NullPointer
>    ColourManagerTest.setup:45 » NullPointer
>    ColourManagerTest.setup:45 » NullPointer
>    ColourManagerTest.setup:45 » NullPointer
> 
> Tests run: 6, Failures: 0, Errors: 5, Skipped: 1
> 
> ------------------------------------------------------------------------
> Reactor Summary:
> 
> Apache Taverna Workbench ........................... SUCCESS [ 33.352 s]
> Apache Taverna Activity icon manager API ........... SUCCESS [02:16 min]
> Apache Taverna Workbench API ....................... SUCCESS [ 2.451 s]
> Apache Taverna Edits API ........................... SUCCESS [ 14.682 s]
> Apache Taverna BeanInfo extensions ................. SUCCESS [ 1.307 s]
> Apache Taverna Activity Palette API ................ SUCCESS [ 30.776 s]
> Apache Taverna Configuration Management UI API ..... SUCCESS [ 1.852 s]
> Apache Taverna User interface (Swing) utilities .... SUCCESS [ 3.546 s]
> Apache Taverna File opening API .................... SUCCESS [ 5.979 s]
> Apache Taverna Help System ......................... SUCCESS [ 9.436 s]
> Apache Taverna Contextual Views API ................ SUCCESS [ 26.341 s]
> Apache Taverna Selection API ....................... SUCCESS [ 4.724 s]
> Apache Taverna Menu generation API ................. SUCCESS [ 7.304 s]
> Apache Taverna Design UI ........................... SUCCESS [ 6.990 s]
> Apache Taverna Workflow View ....................... SUCCESS [ 6.944 s]
> Apache Taverna IO utility classes .................. SUCCESS [ 1.053 s]
> Apache Batik OSGi .................................. SUCCESS [ 38.303 s]
> Apache Taverna Graph Model ......................... SUCCESS [ 28.042 s]
> Apache Taverna Graph View .......................... SUCCESS [ 10.018 s]
> Apache Taverna Activity tools ...................... SUCCESS [ 6.410 s]
> Apache Taverna Edits implementation ................ SUCCESS [ 13.127 s]
> Apache Taverna File opening implementation ......... SUCCESS [ 43.947 s]
> Apache Taverna Dataflow Activity UI ................ SUCCESS [ 15.001 s]
> Apache Taverna StringConstant Activity UI .......... SUCCESS [ 12.468 s]
> Apache Taverna Contextual Views Impl ............... SUCCESS [ 21.565 s]
> Apache Taverna Unrecognized Activity UI ............ SUCCESS [ 6.135 s]
> Apache Taverna Activity Palette Impl ............... SUCCESS [ 24.949 s]
> Apache Taverna UI builder .......................... SUCCESS [ 2.760 s]
> Apache Taverna Activity Palette UI Component ....... SUCCESS [ 7.833 s]
> Apache Taverna Configuration Management UI Impl .... FAILURE [ 9.015 s]
> Apache Taverna Contextual views .................... SKIPPED
> Apache Taverna Credential Manager UI ............... SKIPPED
> Apache Taverna Data management configuration UI .... SKIPPED
> Apache Taverna HTTP Proxy configuration ............ SKIPPED
> Apache Taverna Menu generation impl ................ SKIPPED
> Apache Taverna Reporting API ....................... SKIPPED
> Apache Taverna menu items .......................... SKIPPED
> Apache Taverna Renderers API ....................... SKIPPED
> Apache Taverna Results and outputs ................. SKIPPED
> Apache Taverna Monitor View ........................ SKIPPED
> Apache Taverna Parallelize layer contextual view ... SKIPPED
> Apache Taverna Workflow Explorer ................... SKIPPED
> Apache Taverna Design perspective .................. SKIPPED
> Apache Taverna myExperiment perspective ............ SKIPPED
> Apache Taverna Results Perspective ................. SKIPPED
> Apache Taverna Workbench Plugin Manager ............ SKIPPED
> Apache Taverna Reference manager UI ................ SKIPPED
> Apache Taverna Renderers Implementation ............ SKIPPED
> Apache Taverna Renderers extensions ................ SKIPPED
> Apache Taverna Retry layer contextual view ......... SKIPPED
> Apache Taverna Results UI .......................... SKIPPED
> Apache Taverna Selection Implementation ............ SKIPPED
> Apache Taverna Workbench Update Manager ............ SKIPPED
> Apache Taverna Workbench UI implementation ......... SKIPPED
> ------------------------------------------------------------------------
> BUILD FAILURE
> ------------------------------------------------------------------------
> Total time: 09:18 min
> Finished at: 2017-12-06T13:59:06+01:00
> Final Memory: 90M/814M
> ------------------------------------------------------------------------
> Failed to execute goal 
> org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test 
> (default-test) on project taverna-configuration-ui-impl: There are test 
> failures.
> 
> Please refer to 
> D:\PROJECTS\Taverna\incubator-taverna-workbench\taverna-configuration-impl\target\surefire-reports

> for the individual test results.
> -> [Help 1]
> 
> To see the full stack trace of the errors, re-run Maven with the -e switch.
> Re-run Maven using the -X switch to enable full debug logging.
> 
> For more information about the errors and possible solutions, please 
> read the following articles:
> [Help 1] 
> http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
> 
> After correcting the problems, you can resume the build with the command
>    mvn <goals> -rf :taverna-configuration-ui-impl
> 
> 
> On 12/6/2017 11:53 AM, Stian Soiland-Reyes wrote:
> > We have some outstanding pull requests:
> >
> > https://github.com/apache/incubator-taverna-plugin-bioinformatics/pulls
> > https://github.com/apache/incubator-taverna-plugin-gis/pulls
> > https://github.com/apache/incubator-taverna-common-activities/pulls
> > https://github.com/apache/incubator-taverna-engine/pulls
> > https://github.com/apache/incubator-taverna-commandline/pulls
> > https://github.com/apache/incubator-taverna-server/pulls
> > https://github.com/apache/incubator-taverna-workbench/pulls
> > https://github.com/apache/incubator-taverna-workbench-common-activities/pulls
> >
> > It would be great if anyone could help review+merge these - just reply
> > to this email about which one of the above you pick.
> >
> > Several of these are from committers. If you made the pull request, feel
> > free to merge it.
> >
> >
> 

Mime
View raw message