taverna-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "JC (JIRA)" <j...@apache.org>
Subject [jira] [Created] (TAVERNA-1019) Condition that always returns true
Date Tue, 18 Apr 2017 20:05:41 GMT
JC created TAVERNA-1019:

             Summary: Condition that always returns true
                 Key: TAVERNA-1019
                 URL: https://issues.apache.org/jira/browse/TAVERNA-1019
             Project: Apache Taverna
          Issue Type: Bug
          Components: Taverna Workbench
            Reporter: JC
            Priority: Trivial


In a recent snapshot from Github mirror for incubator-taverna-workbench, I've found following
suspicious code in taverna-edits-impl/src/main/java/org/apache/taverna/workbench/edits/impl/menu/AbstractUndoAction.java

132                 public void notify(Observable<EditManagerEvent> sender,
133                                 EditManagerEvent message) throws Exception {
134                         if (!(message instanceof AbstractDataflowEditEvent))
135                                 return;
136                         AbstractDataflowEditEvent dataflowEdit = (AbstractDataflowEditEvent)
137                         if (dataflowEdit.getDataFlow().equals(dataflowEdit.getDataFlow()))
138                                 // It's an edit that could effect our undoability
139                                 updateStatus();
140                 }

In Line 137, equals compares the same expression. If this is intended, it might not be an
issue but wanted to report just in case. Thanks!

This message was sent by Atlassian JIRA

View raw message