taverna-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From MarkRobbo <...@git.apache.org>
Subject [GitHub] incubator-taverna-common-activities pull request #22: Exception fixes
Date Fri, 07 Oct 2016 15:37:25 GMT
GitHub user MarkRobbo opened a pull request:


    Exception fixes

    I don't think the ClassCastException checking here is needed, and definitely shouldn't
be printing to standard output.
    Removed another check for '$' at the start of input/output type: parameters which seems
to be unnecessary, see [this Gitter chat in common-workflow-language](https://gitter.im/common-workflow-language/common-workflow-language?at=57f7b455dfe82a365b0690f8)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MarkRobbo/incubator-taverna-common-activities exception-fixes

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #22
commit f2fdffa37abd881243e5f84a868b0969bdb03f91
Author: Mark Robinson <mark.robinson-4@student.manchester.ac.uk>
Date:   2016-10-07T14:06:19Z

    Remove ClassCastException catching

commit 2bf60d6f75bae335b502cf1966e13eefd2cd96f2
Author: Mark Robinson <mark.robinson-4@student.manchester.ac.uk>
Date:   2016-10-07T14:49:19Z

    Remove check for $ at start of input


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message