taverna-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From stain <...@git.apache.org>
Subject [GitHub] incubator-taverna-mobile pull request #28: Taverna 2's workflow running feat...
Date Mon, 03 Oct 2016 12:25:41 GMT
Github user stain commented on a diff in the pull request:

    https://github.com/apache/incubator-taverna-mobile/pull/28#discussion_r81539219
  
    --- Diff: app/src/main/java/org/apache/taverna/mobile/data/local/PreferencesHelper.java
---
    @@ -49,11 +52,19 @@
     
         private static final String PREF_KEY_USER_WEBSITE = "pref_user_website";
     
    +    private static final String PREF_KEY_PLAYER_CREDENTIAL = "pref_player_credential";
    +
    +    public static final String PREF_KEY_PLAYER_URL = "pref_player_url";
    +
    +    public static final String PLAYER_DEFAULT_URL = "http://139.59.28.12:3000/";
    --- End diff --
    
    Could we avoid hard-coding this particular server? I have no idea which server that is..
:)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message