Mailing-List: contact dev-help@taverna.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@taverna.incubator.apache.org
From: stain <git@git.apache.org>
To: dev@taverna.incubator.apache.org
Reply-To: dev@taverna.incubator.apache.org
References: <git-pr-13-incubator-taverna-common-activities@git.apache.org>
In-Reply-To: <git-pr-13-incubator-taverna-common-activities@git.apache.org>
Subject: [GitHub] incubator-taverna-common-activities pull request #13: Taverna 3
Content-Type: text/plain
Message-Id: <20160712200832.22676DFF68@git1-us-west.apache.org>
Date: Tue, 12 Jul 2016 20:08:31 +0000 (UTC)
archived-at: Tue, 12 Jul 2016 20:08:37 -0000

Github user stain commented on a diff in the pull request:

    https://github.com/apache/incubator-taverna-common-activities/pull/13#discussion_r70512153
  
    --- Diff: taverna-cwl-activity/src/main/java/org/apache/taverna/cwl/CwlActivityFactory.java ---
    @@ -0,0 +1,102 @@
    +/*
    +* Licensed to the Apache Software Foundation (ASF) under one
    +* or more contributor license agreements. See the NOTICE file
    +* distributed with this work for additional information
    +* regarding copyright ownership. The ASF licenses this file
    +* to you under the Apache License, Version 2.0 (the
    +* "License"); you may not use this file except in compliance
    +* with the License. You may obtain a copy of the License at
    +*
    +* http://www.apache.org/licenses/LICENSE-2.0
    +*
    +* Unless required by applicable law or agreed to in writing,
    +* software distributed under the License is distributed on an
    +* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +* KIND, either express or implied. See the License for the
    +* specific language governing permissions and limitations
    +* under the License.
    +*/
    +package org.apache.taverna.cwl;
    +
    +import java.net.URI;
    +import java.util.HashMap;
    +import java.util.HashSet;
    +import java.util.Set;
    +
    +import org.apache.log4j.Logger;
    +import org.apache.taverna.cwl.utilities.CWLUtil;
    +import org.apache.taverna.workflowmodel.Edits;
    +import org.apache.taverna.workflowmodel.processor.activity.Activity;
    +import org.apache.taverna.workflowmodel.processor.activity.ActivityConfigurationException;
    +import org.apache.taverna.workflowmodel.processor.activity.ActivityFactory;
    +import org.apache.taverna.workflowmodel.processor.activity.ActivityInputPort;
    +import org.apache.taverna.workflowmodel.processor.activity.ActivityOutputPort;
    +
    +import com.fasterxml.jackson.databind.JsonNode;
    +
    +public class CwlActivityFactory implements ActivityFactory {
    +	private static Logger logger = Logger.getLogger(CwlActivityFactory.class);
    +	private static final int DEPTH_0 = 0;
    +	private static final int DEPTH_1 = 1;
    +	private Edits edits;
    +
    +	@Override
    +	public Activity<?> createActivity() {
    +		CwlDumyActivity activity = new CwlDumyActivity();
    +		activity.setEdits(edits);
    +		return activity;
    +	}
    +
    +	@Override
    +	public URI getActivityType() {
    +		return null;
    +	}
    +
    +	@Override
    +	public JsonNode getActivityConfigurationSchema() {
    +		return null;
    +	}
    +
    +	@Override
    +	public Set<ActivityInputPort> getInputPorts(JsonNode configuration) throws ActivityConfigurationException {
    --- End diff --
    
    Yes, great! This also uses CWLUtil, so that is nice.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---