taverna-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gale Naylor <Ga...@noventussolutions.com>
Subject Re: [DISCUSS] Release candidate 2 of Command-line Tool 3.1.0-incubating
Date Thu, 02 Jun 2016 18:50:56 GMT
I'm so sorry - I've been replying to the VOTE thread.

I'll copy my comments here:

------------------------------------------
UP-FRONT CHECKS
------------------------------------------
The MD5 checksums in the [VOTE] email are the same as the SHA1 checksums.
I'm using the downloaded MD5 and SHA-1.

(Originally I missed the commit IDs in the Vote email - don't know how -
but they are there.)


------------------------------------------
LICENSES - THIRD-PARTY.properties file
------------------------------------------

-------------------
GNU License?

The list of # Already used licenses in project : includes

# - GNU Lesser General Public License, Version 2.1
Isn't this a category-x license? (It doesn't show up in the
"Please fill in the missing licenses" list at the bottom of the file.)


-------------------
Missing license information:

# http://x-stream.github.io/license.html - this link says BSD (but not
which type);
should this copyright be included in our Notice file?

org.aopalliance--com.springsource.org.aopalliance--1.0.0  - no license
listed

# https://github.com/hunterhacker/jdom/blob/jdom-1.1/core/LICENSE.txt  -
this link has a copyright;
include in Notice file? What do we use for "type" of license? "Copyright?"
Or is this also a "JDOM License" like
org.jdom--com.springsource.org.jdom--1.1.0?

# http://www.xmlpull.org/  - no license listed


-------------------
Category B licenses?

Aren't the following licenses listed under category-b, binary release only?
Or do they meet the exception
for allowing in a source release? ("For small amounts of source that is
directly
consumed by the ASF product at runtime in source form, and for which that
source is unmodified and unlikely to be changed ...")

javax.transaction--com.springsource.javax.transaction--1.1.0 - CDDL 1.0

org.aspectj--com.springsource.org.aspectj.runtime--1.6.0 - Eclipse Public
License 1.0
org.aspectj--com.springsource.org.aspectj.weaver--1.6.0 - Eclipse Public
License 1.0


-------------------
Source File Headers
-------------------

-------------------
Non-ASF Copyrights


1) University of Manchester copyright in taverna-provenanceconnector
files (see previous email).

2) taverna-execution-hadoop Crossproduct.java file contains copyright
by Adam Pingel and no ASF license.

     I know this is copyright is included in the top level NOTICE
     file, but doesn't it have to be removed from the Java file?


-------------------
Missing ASF licenses?


1) Two README files without license headers:

/taverna-engine-rc2/taverna-prov/README.md
/taverna-engine-rc2/taverna-reference-types/README.md


2) One JSON file without license header

/taverna-engine-rc2/taverna-run-impl/src/test/resources/workflowrun.json


3) Miscellaneous text and html files don't have a license header.
(Also spring.handlers and spring.schemas.)
Are these not considered "code?"

Examples:
taverna-activity-archetype...goal.txt,
taverna-credential-manager...text.html,
taverna-prov...3a/3a82e39d-a537-40cf-91a0-2c89d4a2e62b.txt
taverna-prov...greeting.txt
taverna-prov...mimetype
taverna-workflowmodel-impl...package.html
taverna-reference-impl...spring.handlers (and spring.schemas)


4) Files in services subdirectories also do not have a license headers. Are
they exempt?

Examples:
taverna-credential-manager...services/
org.apache.taverna.security.credentialmanager.CredentialProviderSPI
taverna-dataflow-activity.../services/
net.sf.taverna.t2.workflowmodel.health.HealthChecker


 Gale


On Wed, Jun 1, 2016 at 7:21 AM Stian Soiland-Reyes <stain@apache.org> wrote:

> Great! Yes, the long one sounds like trouble..
>
> The README says:
>
> https://github.com/apache/incubator-taverna-engine/#building-on-windows
>
> > If you are building on Windows, ensure you unpack this source code to a
> folder with a short path name lenght, e.g. C:\src - as Windows has a
> limitation on the total path length which might otherwise prevent this code
> from building successfully.
>
> I tested mine as D:\apache-taverna-engine-3.1.0-incubating\ which just
> about worked.
>
> I am not sure if Maven could detect this in advance somehow, perhaps
> something to ask on dev@maven.. (I'll ask)
>
>
> On 1 June 2016 at 13:18, Alan Williams <alaninmcr@googlemail.com> wrote:
> > On 01-Jun-16 12:27, Alan Williams wrote:
> >>
> >> Hello
> >>
> >> I get a failure:
> >>
> >> [INFO] [ERROR] Failed to execute goal
> >> org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test
> >> (default-test) on project dummy-taverna-plugin-activity: Execution
> >> default-test of goal
> >> org.apache.maven.plugins:maven-surefire-plugin:2.19.1:t
> >> est failed: The forked VM terminated without properly saying goodbye. VM
> >> crash or System.exit called?
> >> [INFO] [ERROR] Command was cmd.exe /X /C ""C:\Program
> >> Files\Java\jdk1.8.0_51\jre\bin\java" -jar
> >>
> >>
> C:\Users\alson\taverna\apache-taverna-engine-3.1.0-incubating-source-release\apache-taverna-engine-3.1.0-incubating\taverna-activity-archetype\target\test-classes\projects\dummyActivity\project\dummy-taverna-plugin\dummy-taverna-plugin-activity\target\surefire\surefirebooter1896791380795738239.jar
> >> C:\Us
> >>
> >>
> ers\alson\taverna\apache-taverna-engine-3.1.0-incubating-source-release\apache-taverna-engine-3.1.0-incubating\taverna-activity-archetype\target\test-classes\projects\dummyActivity\project\dummy-taverna-plugin\dummy-taverna-plugin-activity\target\surefire\surefire5943729575219558115tmp
> >>
> >>
> C:\Users\alson\taverna\apache-taverna-engine-3.1.0-incubating-source-release\apache-taverna-engine-3.1.0-incubating\taverna-activity-archetype\target\test-classes\projects\dummyActivity\project\dummy-taverna-plugin\dummy-taverna-plugin-activity\target\surefire\surefire_0317696432267187850tmp"
> >>
> >>
> >> Is that the path length limit problem?
> >
> >
> > It built OK when I just had it under C:\engine instead of
> >
> C:\Users\alson\taverna\apache-taverna-engine-3.1.0-incubating-source-release\apache-taverna-engine-3.1.0-incubating
> >
> >> Alan
> >
> >
> > Alan
>
>
>
> --
> Stian Soiland-Reyes
> Apache Taverna (incubating), Apache Commons
> http://orcid.org/0000-0001-9842-9718
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message