taverna-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gale Naylor <Ga...@noventussolutions.com>
Subject Re: Taverna Mobile Application
Date Fri, 03 Jun 2016 13:00:55 GMT
Thanks, Rajan!

On Thu, Jun 2, 2016, 8:15 PM Rajan Maurya <rajanmaurya154@gmail.com> wrote:

> Hi Gale,
>
> Ok, Actually I forget to mention the GitHub PR.
>
> Here is some point need to fix first to merge the PR
>
>    1. Implement Parcelable in POJO for making faster HTTPS Calls
>    2.
>
>    Do not make multiple POJO class in single like you have done here
>
>  app/src/main/java/org/apache/taverna/mobile/data/model/Announcement.java.
>    Made author POJO in Announcement POJO because author POJO will be used
>    further in many places in future so make it separate.
>    3.
>
>    When you will make separate POJOs then you do not need the hierarchical
>    initialization of List. It's not good practice.
>    4.
>
>    Naming convention mMainPresenter in AnnouncementFragment, make it
>    mAnnouncementPresenter. It can be good. for future follow this
>
> https://github.com/ribot/android-guidelines/blob/master/project_and_code_guidelines.md#2-code-guidelines
>     .
>    5.
>
>    You are using ConnectivityManager for checking internet connection two
>    times in the same file bad practice.
>    I suggest making a util/ConnectionInfo something class to use anywhere
>    you need to check internet connection.
>    6.
>
>    What about if the loading data failed from the internet. Implement
>    showResponseError.
>
>
> Thanks
>
>
>
>
> On Fri, Jun 3, 2016 at 3:37 AM, Gale Naylor <GaleN@noventussolutions.com>
> wrote:
>
> > Hi Rajan,
> >
> > The dev@taverna mailing list is intended to collect all development
> work,
> > including things like your suggested fixes to the Taverna Mobile App!
> >
> > Can you please include your suggestions in an email to the dev list? (A
> > reply to this email would make sense.)
> >
> > Thanks!
> >
> > Gale
> >
> > On Thu, Jun 2, 2016 at 10:28 AM Rajan Maurya <rajanmaurya154@gmail.com>
> > wrote:
> >
> > > Hi Sagar,
> > >
> > > I have reviewed the PR.
> > > Please look and fix all of these that i have mentioned.
> > >
> > > Thanks
> > > On Jun 2, 2016 11:23 AM, "Rajan Maurya" <rajanmaurya154@gmail.com>
> > wrote:
> > >
> > > > Hi Sagar,
> > > >
> > > > Its looks good. I will review it today and update you if  there is
> any
> > > > need to change.
> > > >
> > > > Implement rest of  Announcement Details part
> > > >
> > > > Good :)
> > > >
> > > >
> > > > On Thu, Jun 2, 2016 at 10:58 AM, Sagar <kumarsagar15795@gmail.com>
> > > wrote:
> > > >
> > > >> Hi All,
> > > >>     My semester end exam gone well and I am starting my internship
> on
> > > this
> > > >> project as we talk earlier, Now I started working on Taverna Mobile
> > > >> Application.
> > > >>
> > > >> I go through Rajan Maurya's GsoC proposal and found he researched
> well
> > > and
> > > >> I am following it as accordingly.
> > > >>
> > > >>  I have sent  a pull request (PR no #14
> > > >> <https://github.com/apache/incubator-taverna-mobile/pull/14>)
 and
> I
> > > have
> > > >> added some libraries and start working on  Announcements features.
> > > >>
> > > >>    - Added MVP architecture basic
> > > >>    - Setup Retrofit
> > > >>    - Setup Simple xml parser
> > > >>    - Setup Rx-JAVA and Rx-Android
> > > >>    - Setup ButterKnife
> > > >>    - Design Announcement layout
> > > >>    - Working ListView to show all Announcements
> > > >>    - [WIP] Detail of clicked Announcement
> > > >>
> > > >> I am currently working on it.
> > > >>
> > > >> Rajan Maurya, Please reviews the #PR
> > > >> <https://github.com/apache/incubator-taverna-mobile/pull/14>
till
> now
> > > >> and
> > > >> suggests me something if there is something needed to change .
> > > >>
> > > >> If anyone else wants to work on it or review my work, it'd be great.
> > > >>
> > > >> --
> > > >>
> > > >> *With warm regards  *
> > > >> *Sincerely yours*
> > > >> Sagar
> > > >>
> > > >>
> > > >> *Student ,(6th Semester )B.Tech IT and mathematical innovation*
> > > >> *Cluster Innovation Centre*
> > > >> *University of Delhi *
> > > >>
> > > >
> > > >
> > > >
> > > > --
> > > > *Thanks*
> > > > *Namaste*
> > > >
> > > > Rajan Maurya
> > > > Contact Number : +91 8010665248
> > > > Github : https://github.com/therajanmaurya
> > > > College : Cluster Innovation Centre, University of Delhi
> > > > Student : B.Tech. (Information Technology & Mathematical Innovations)
> > > >
> > > >
> > >
> >
>
>
>
> --
> *Thanks*
> *Namaste*
>
> Rajan Maurya
> Contact Number : +91 8010665248
> Github : https://github.com/therajanmaurya
> College : Cluster Innovation Centre, University of Delhi
> Student : B.Tech. (Information Technology & Mathematical Innovations)
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message