taverna-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stian Soiland-Reyes (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TAVERNA-893) Make download code more robust.
Date Sat, 13 Feb 2016 14:02:18 GMT

    [ https://issues.apache.org/jira/browse/TAVERNA-893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15145979#comment-15145979
] 

Stian Soiland-Reyes commented on TAVERNA-893:
---------------------------------------------

Fixed in taverna-osgi - now uses httpclient 4.5.1 with fallback to java.nio.Path for file:///
support. Default timeout is now 30 seconds (not milliseconds!) - per request and connection
- so in total the timeout could be 2 minutes per download. 

The timeout can now be modified by setting the system property taverna.download.timeout.seconds
-- I guess ideally this should be an OSGi configuration thingie, but a system property is
better than hard-coded constants.

I also changed the hashing checks so it supports sha1, sha256 etc, not just md5.

Before URLs like ftp:// and jar: might have been accidentally supported through Java's URLConnection
- these are no longer supported. I don't think we want to support those anyway.

I changed the API signatures (now while we have the chance :) of download-api to take URI,Path
instead of old-skool URL,File.

Note that there are quite a few other API signatures with File across taverna-osgi - they
should ideally also be fixed to Path now with Java 7 (I mean 8!) as default, but it was a
bit too big change for now as it affects the implementations on how they store their configuration.

> Make download code more robust.
> -------------------------------
>
>                 Key: TAVERNA-893
>                 URL: https://issues.apache.org/jira/browse/TAVERNA-893
>             Project: Apache Taverna
>          Issue Type: Bug
>          Components: Taverna OSGi
>            Reporter: Gale Naylor
>            Assignee: Stian Soiland-Reyes
>            Priority: Minor
>
> Ensure download code saves only valid POM files. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message