taverna-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andy Seaborne <a...@apache.org>
Subject Re: TAVERNA-867 doclint javadoc and Java 7 (was: Snapshot issue when releasing taverna language)
Date Mon, 01 Feb 2016 17:46:52 GMT
Jena has to turn off Java8 doclint because it fails builds for imperfect 
javadoc.

     <profile>
       <!-- Turn of doclint for java8 and later -->
       <id>doclint-java8-disable</id>
       <activation>
         <jdk>[1.8,)</jdk>
       </activation>

       <build>
         <plugins>
           <plugin>
             <groupId>org.apache.maven.plugins</groupId>
             <artifactId>maven-javadoc-plugin</artifactId>
             <configuration>
               <additionalparam>-Xdoclint:none</additionalparam>
             </configuration>
           </plugin>
         </plugins>
       </build>
     </profile>

We also have the problem with false warnings

[WARNING] 
/home/jenkins/jenkins-slave/workspace/Jena_Development_Deploy/jena-core/src/main/java/org/apache/jena/ontology/OntProperty.java:497:

warning - @propertyDescription is an unknown tag.

except there is no @propertyDescription in the source!

@propertyDescription can only be used in JavaFX properties getters and 
setters.
[WARNING] 
/home/jenkins/jenkins-slave/workspace/Jena_Development_Deploy/jena-core/src/main/java/org/apache/jena/ontology/OntProperty.java:490:

warning - Tags @propertyGetter, @propertySetter and @propertyDescription 
can only be used in JavaFX properties getters and setters.

JavaFX ???!!!!

	Andy

On 01/02/16 17:01, Stian Soiland-Reyes wrote:
> Yes, I think ironically we need it to ignore some errors from Java 8's
> javadoc - this came up as we were doing the 0.15.0 release of
> taverna-language.
>
> See also:
> https://issues.apache.org/jira/browse/MJAVADOC-387
>
>
> You can also enable it conditionally with <profile> based on the JDK
> version like here:
>
> https://github.com/jai-imageio/jai-imageio-core/blob/master/pom.xml#L195
>
> If we do that we can keep 1.7 support - I mean if we really want to. :)
>
>
>
> Alternatively I guess we can go through and fix the Javadoc warnings..
>
> Some examples:
>
>
> [ERROR] /home/stain/src/taverna/incubator-taverna-language/taverna-scufl2-ucfpackage/src/main/java/org/apache/taverna/scufl2/ucfpackage/impl/odfdom/pkg/OdfPackage.java:910:
> warning: no description for @throws
> [ERROR] * @throws Exception
> [ERROR] ^
>
> [ERROR] /home/stain/src/taverna/incubator-taverna-language/taverna-scufl2-ucfpackage/src/main/java/org/apache/taverna/scufl2/ucfpackage/impl/odfdom/pkg/manifest/OdfFileEntry.java:87:
> warning: no @return
> [ERROR] public int getSize() {
> [ERROR] ^
>
> [ERROR] /home/stain/src/taverna/incubator-taverna-language/taverna-scufl2-ucfpackage/target/generated-sources/xjc/org/oasis_open/names/tc/opendocument/xmlns/container/ObjectFactory.java:125:
> warning: no @param for value
> [ERROR] public JAXBElement<Relationship>
> createContainerRelationshipsRelationship(Relationship value) {
> [ERROR] ^
>
> There would be quite a few warnings.. I wonder if the Doclint default
> has changed with OpenJDK vs Oracle JDK or in different Java patch
> versions, because if I try on my machine to remove the doclint setting
> taverna-language still builds, using OpenJDK 1.8.0_72-internal on
> Ubuntu 14.04.3/x64.
>
> (I had to change to -Xdoclint:all to see those warnings)
>
> On 1 February 2016 at 14:49, alaninmcr <alaninmcr@googlemail.com> wrote:
>> On 01/02/2016 12:35, Menaka Madushanka wrote:
>>>
>>> Hello,
>>> I get this error when building tavlang tool....
>>>
>>> [ERROR] Failed to execute goal
>>> org.apache.maven.plugins:maven-javadoc-plugin:2.9:jar (attach-javadocs) on
>>> project taverna-language-commandline: MavenReportException: Error while
>>> creating archive:
>>> [ERROR] Exit code: 1 - javadoc: error - invalid flag: -Xdoclint:none
>>> [ERROR]
>>> [ERROR] Command line was: /usr/lib/jvm/java-7-oracle/jre/../bin/javadoc
>>> @options @packages
>>
>>
>> Is that option only available in Java 8?
>>
>> Alan
>
>
>


Mime
View raw message