Return-Path: X-Original-To: apmail-taverna-dev-archive@minotaur.apache.org Delivered-To: apmail-taverna-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 53A6B18F9E for ; Tue, 4 Aug 2015 10:33:08 +0000 (UTC) Received: (qmail 22978 invoked by uid 500); 4 Aug 2015 10:33:08 -0000 Delivered-To: apmail-taverna-dev-archive@taverna.apache.org Received: (qmail 22938 invoked by uid 500); 4 Aug 2015 10:33:08 -0000 Mailing-List: contact dev-help@taverna.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@taverna.incubator.apache.org Delivered-To: mailing list dev@taverna.incubator.apache.org Received: (qmail 22927 invoked by uid 99); 4 Aug 2015 10:33:07 -0000 Received: from Unknown (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 04 Aug 2015 10:33:07 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 928A0C1311 for ; Tue, 4 Aug 2015 10:33:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.97 X-Spam-Level: X-Spam-Status: No, score=0.97 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-eu-west.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id D25lgEStAbR1 for ; Tue, 4 Aug 2015 10:33:06 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-eu-west.apache.org (ASF Mail Server at mx1-eu-west.apache.org) with SMTP id 146D724E12 for ; Tue, 4 Aug 2015 10:33:05 +0000 (UTC) Received: (qmail 22072 invoked by uid 99); 4 Aug 2015 10:33:05 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 04 Aug 2015 10:33:05 +0000 Date: Tue, 4 Aug 2015 10:33:04 +0000 (UTC) From: "Ian Dunlop (JIRA)" To: dev@taverna.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (TAVERNA-847) Fix workflow mark as favorite MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/TAVERNA-847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14653426#comment-14653426 ] Ian Dunlop commented on TAVERNA-847: ------------------------------------ Seems to work OK now for workflows that have not been favourited before. I think instead of alerting users that a workflow has already been marked as favorite when they click it again it should remove it from the favorite list. I like that the button is now coloured grey to show that it is a favourite. However, I noticed that when starting the app, workflows that had been marked as favourites were correctly marked grey but you could click and add them to favourites again. Only once though, after clicking them you can't then add again. > Fix workflow mark as favorite > ------------------------------ > > Key: TAVERNA-847 > URL: https://issues.apache.org/jira/browse/TAVERNA-847 > Project: Apache Taverna > Issue Type: Task > Components: GSOC: Taverna Mobile > Affects Versions: parent 1 > Environment: Android studio 1.1.0 > Reporter: larry akah > Assignee: larry akah > Labels: features > Fix For: parent 1 > > Original Estimate: 72h > Remaining Estimate: 72h > > Fix the marking a workflow as favorite such that it gets added to the local database properly and also how the button transitions to indicate the state. it requires adding an entity seprately to the database when a given workflow item is selected from the list. -- This message was sent by Atlassian JIRA (v6.3.4#6332)