Mailing-List: contact dev-help@taverna.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@taverna.incubator.apache.org
MIME-Version: 1.0
In-Reply-To: <55B8DBC7.2040806@manchester.ac.uk>
References: <55B8DBC7.2040806@manchester.ac.uk>
From: Stian Soiland-Reyes <stain@apache.org>
Date: Fri, 31 Jul 2015 16:15:28 +0100
Message-ID: 
 <CAMBJEmVHi2viiXAw7mztStbrFMb+7-am9G9AeuP+sk6_PMUrcQ@mail.gmail.com>
Subject: Re: [VOTE] Release Apache Taverna Parent 1-incubating-RC4 & Apache
 Taverna Language 0.15.0-incubating RC4
To: dev@taverna.incubator.apache.org
Content-Type: text/plain; charset=UTF-8

Here is my vote:

+1


+ md5 and sha1 sums correct against email and *.sha1 /*.md5
+ Content matches git checkout - somewhat (1)
-  FAILS builds with Java 7 (2)
+ Builds with mvn clean install for Java 8 (3)
+ No unexpected binaries (4)
+ mvn clean apache-rat:check is ~happy (5)
+ LICENSE/NOTICE/DISCLAIMER present
++ LICENSE acknowledges third-parties where needed
++ No additional NOTICE needed
+ No incompatible dependency licenses (6)


(1)
Using the ^1 commits, ignoring .gitignore and CR+LF differences from
Windows by checking with git diff -w

Why do not mvn release plugin check these out with native file
endings? Something to check - perhaps release process needs to specify
crlf behaviour in .gitconfig for Windows users?

(2)
stain@biggie:/tmp/91/taverna-parent-1-incubating-RC4/taverna-parent-1-incubating$
mvn -v
Apache Maven 3.3.3 (7994120775791599e205a5524ec3e0dfe41d4a06;
2015-04-22T12:57:37+01:00)
Maven home: /home/stain/software/maven
Java version: 1.7.0_79, vendor: Oracle Corporation
Java home: /usr/lib/jvm/java-7-openjdk-amd64/jre
Default locale: en_GB, platform encoding: UTF-8
OS name: "linux", version: "3.16.0-43-generic", arch: "amd64", family: "unix"


..
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-javadoc-plugin:2.9:jar
(attach-javadocs) on project taverna-baclava-language:
MavenReportException: Error while creating archive:
[ERROR] Exit code: 1 - javadoc: error - invalid flag: -Xdoclint:none

This is caused by Java 7 ironically not supporting the flag added for
Java 8 to support Java 7-style javadocs.. :-/


The included README says:

> ## Prerequisites
> * Java 1.7 or newer (tested with OpenJDK 1.8)

To work around it for 1.7 you can add -Dmaven.javadoc.skip=true

.. obviously if we want to add that to the README we would need yet
another VOTE :-(

Java 1.7 reached End of Life in April 2015 - so I don't think this is
a big blocker, hence my 0 instead of -1 here.

I fixed it in README for the next release:
https://github.com/apache/incubator-taverna-language/blob/master/README.md#prerequisites


(3)
stain@biggie:/tmp/91/taverna-language-0.15.0-incubating-RC4/taverna-language-0.15.0-incubating$
mvn -version
Apache Maven 3.3.3 (7994120775791599e205a5524ec3e0dfe41d4a06;
2015-04-22T12:57:37+01:00)
Maven home: /home/stain/software/maven
Java version: 1.8.0_45-internal, vendor: Oracle Corporation
Java home: /usr/lib/jvm/java-8-openjdk-amd64/jre
Default locale: en_GB, platform encoding: UTF-8
OS name: "linux", version: "3.16.0-43-generic", arch: "amd64", family: "unix"


(4)
Except test workflows as *.wfbundle and two diagrams as *.png


(5)
Except the empty DEPENDENCIES of taverna-maven-parent

(6)
According to http://www.apache.org/legal/resolved.html

Tested with
mvn license:aggregate-add-third-party

stain@biggie:/tmp/91/taverna-language-0.15.0-incubating-RC4/taverna-language-0.15.0-incubating$
cat target/generated-sources/license/THIRD-PARTY.txt | grep -v Apache
| grep -v BSD | grep -v MIT | grep -v CDDL | grep -v Common.Public

Lists of 67 third-party dependencies.
     (Unknown license) com.springsource.org.jaxen
(org.jaxen:com.springsource.org.jaxen:1.1.1 - no url defined)
     (Unknown license) com.springsource.org.jdom
(org.jdom:com.springsource.org.jdom:1.1.0 - no url defined)


Jaxen and JDOM have previously been checked as BSD-like

http://dev.mygrid.org.uk/wiki/display/developer/Third-party+licenses

On 29 July 2015 at 14:57, Ian Dunlop <ian.dunlop@manchester.ac.uk> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA256
>
> I am pleased to be calling this vote for the source release of
>
> Apache Taverna Parent 1-incubating
> Apache Taverna Language 0.15.0-incubating
>
> Apache Taverna Language is a set of APIs for workflow definitions
> (SCUFL2) and workflow inputs/outputs/run (DataBundle), as consumed and
> produced by the Apache Taverna workflow system. The API includes
> support for working with Research Object Bundles, and loading/saving
> Taverna workflows in different formats.
>
> The release candidates to be voted over are available at:
>
> https://dist.apache.org/repos/dist/dev/incubator/taverna/source/taverna-
> parent-1-incubating-RC4/
> https://dist.apache.org/repos/dist/dev/incubator/taverna/source/taverna-
> language-0.15.0-incubating-RC4/
>
> SHA-1 checksums:
> 3eb09278b914b96fb5c6059523b1bb3e69a09334
> taverna-parent-1-incubating-source-release.zip
> 4eeb37d141fea284cc8de17635d97a47b279ea91
> taverna-language-0.15.0-incubating-source-release.zip
>
> MD5 checksums:
> bccfe1116189f5ccc640fcbed4a4f96f
> taverna-parent-1-incubating-source-release.zip
> 685b3aed3833a0b921d129995944dfc3
> taverna-language-0.15.0-incubating-source-release.zip
>
> Build the release candidate in the above order, using:
>
> mvn clean install
> The release candidates correspond to the following git commits:
>
> https://git-wip-us.apache.org/repos/asf?p=incubator-taverna-maven-parent
> .git;a=commit;h=3595851a840c4a8a087e1df459e6e7d788c78c51
> https://git-wip-us.apache.org/repos/asf?p=incubator-taverna-language.git
> ;a=commit;h=e8c20e79b01c2644448a4e8d5f3bca87b9a6448b
>
> Release candidates are signed with a GPG key available at:
>
> https://dist.apache.org/repos/dist/release/incubator/taverna/KEYS
>
> A staged Maven repository is available for review at:
>
> https://repository.apache.org/content/repositories/orgapachetaverna-1006
> /
>
> The changelog for this release is available from JIRA:
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=1231832
> 2&version=12332247
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=1231832
> 2&version=12332246
>
> Please vote on releasing these packages as:
>
> Apache Taverna Maven Parent 1-incubating
> Apache Taverna Language 0.15.0-incubating
>
> The vote is open for at least 72 hours and passes if a majority of at
> least three +1 Apache Taverna PPMC votes are cast.
>
> [ ] +1 Release this package [ ] 0 I don't feel strongly about it, but
> don't object [ ] -1 Do not release this package because...
>
> Anyone can participate in testing and voting, not just committers,
> please feel free to try out the release candidate and provide your votes
> .
>
> A separate [DISCUSS] thread will be opened to talk about these release
> candidates.
>
> Cheers,
>
> Ian
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v2
>
> iQEcBAEBCAAGBQJVuNvHAAoJEPK45GBX+Cy5MEYH/0jyHDcfq8OkyDhqZjrvPk3W
> CokRytQhgVR9qWyCVXxZvTB7RsFr1BD9GUz8EZb/wyBAhNs5owJzDy2XsA+ipFii
> lTs84/t+vhOL06f/r0uzJ/5b4NoSUPAZ3NFv0GTVgl+HndpAGmVDExbz1u/bqZgd
> VD30adZ5InkZcrHVYjFLxxnRER9WRZMuw21zQO3MlOSq2f7EcixdtG+7efe3CAAG
> 1xN/fgSruBpGpQtXbdUSkSuBEHmm0ciboHJmzL6F4R7Bnee1mjsUK6xOtv+RJBgk
> AphDVcsN8XnxKpBoGuBlzbBHW2byNxsw+bNinHMazTxwuigoIo+BUuPURF/cbpc=
> =dMi5
> -----END PGP SIGNATURE-----


-- 
Stian Soiland-Reyes
Apache Taverna (incubating), Apache Commons RDF (incubating)
http://orcid.org/0000-0001-9842-9718