Return-Path: X-Original-To: apmail-taverna-dev-archive@minotaur.apache.org Delivered-To: apmail-taverna-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2797017BB5 for ; Fri, 6 Mar 2015 16:39:40 +0000 (UTC) Received: (qmail 96623 invoked by uid 500); 6 Mar 2015 16:39:40 -0000 Delivered-To: apmail-taverna-dev-archive@taverna.apache.org Received: (qmail 96589 invoked by uid 500); 6 Mar 2015 16:39:40 -0000 Mailing-List: contact dev-help@taverna.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@taverna.incubator.apache.org Delivered-To: mailing list dev@taverna.incubator.apache.org Received: (qmail 96578 invoked by uid 99); 6 Mar 2015 16:39:40 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 06 Mar 2015 16:39:40 +0000 X-ASF-Spam-Status: No, hits=0.0 required=5.0 tests= X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Fri, 06 Mar 2015 16:39:35 +0000 Received: (qmail 95801 invoked by uid 99); 6 Mar 2015 16:39:15 -0000 Received: from mail-relay.apache.org (HELO mail-relay.apache.org) (140.211.11.15) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 06 Mar 2015 16:39:15 +0000 Received: from mail-lb0-f181.google.com (mail-lb0-f181.google.com [209.85.217.181]) by mail-relay.apache.org (ASF Mail Server at mail-relay.apache.org) with ESMTPSA id 64EC41A026E for ; Fri, 6 Mar 2015 16:39:15 +0000 (UTC) Received: by lbiz12 with SMTP id z12so35909285lbi.5 for ; Fri, 06 Mar 2015 08:39:14 -0800 (PST) X-Gm-Message-State: ALoCoQkDlT1YP4ZeRT5yRxQ/xb2sAm7bLr9SIeHG68e1VpFuAYlVZf2MehWkAOLS2TwGyUl8Yged X-Received: by 10.112.39.69 with SMTP id n5mr13721587lbk.1.1425659954066; Fri, 06 Mar 2015 08:39:14 -0800 (PST) MIME-Version: 1.0 Received: by 10.112.205.169 with HTTP; Fri, 6 Mar 2015 08:38:52 -0800 (PST) X-Originating-IP: [130.88.195.118] In-Reply-To: References: <2476736171ee4560aa82084a571c59e2@git.apache.org> From: Stian Soiland-Reyes Date: Fri, 6 Mar 2015 16:38:52 +0000 Message-ID: Subject: Re: Git Push Summary To: dev@taverna.incubator.apache.org Content-Type: text/plain; charset=UTF-8 X-Virus-Checked: Checked by ClamAV on apache.org Never mind the logic question.. I Was looking at https://github.com/apache/incubator-taverna-common-activities/blob/master/taverna-beanshell-activity/src/main/java/net/sf/taverna/t2/activities/dependencyactivity/AbstractAsynchronousDependencyActivity.java#L267 ..which seems to build a big dependency list for every dependency activity in the workflow - even if the classloader sharing is not set to "workflow". But the only other option now in the enum is "system" which would still cover the whole workflow. On 6 March 2015 at 16:34, Stian Soiland-Reyes wrote: > As followers on the popular commits mailing list might have spotted, I > added the "dependency activity" to incubator-taverna-common-activities > - I forgot this behind in the original repository. > > This is not really an activity, but just an abstract superclass that > now in Taverna 3 is only used by Beanshell Activity (it was also used > by API Consumer Activity). > > I therefore moved it into the beanshell-activity: > > https://github.com/apache/incubator-taverna-common-activities/tree/master/taverna-beanshell-activity/src/main/java/net/sf/taverna/t2/activities/dependencyactivity > > > Note that bits of this logic don't seem to be quite right - > > On 6 March 2015 at 16:09, wrote: >> Repository: incubator-taverna-common-activities >> Updated Tags: refs/tags/old/dependency-activity-0.6 [created] e04738d83 >> refs/tags/old/dependency-activity-0.7 [created] cea3a4296 >> refs/tags/old/dependency-activity-0.8 [created] 48e4d97b4 >> refs/tags/old/dependency-activity-0.9 [created] d5389ddfa >> refs/tags/old/dependency-activity-1.0 [created] 7259bc762 >> refs/tags/old/dependency-activity-1.0.1 [created] f3ab369c6 >> refs/tags/old/dependency-activity-1.1 [created] c6b983145 >> refs/tags/old/dependency-activity-1.2 [created] e7b4364c9 >> refs/tags/old/dependency-activity-1.3 [created] 947b75cfa >> refs/tags/old/dependency-activity-1.4 [created] 8378cad2d >> refs/tags/old/dependency-activity-1.5 [created] 9056c1451 >> refs/tags/old/dependency-activity-2.0.0 [created] 2a17fb740 >> refs/tags/old/dependency-activity-maintenance-2010-09-06 [created] ac10a0d89 >> refs/tags/old/dependency-activity-pre-incubator-20150306 [created] eaa15e216 > > > > -- > Stian Soiland-Reyes > Apache Taverna (incubating) > http://orcid.org/0000-0001-9842-9718 -- Stian Soiland-Reyes Apache Taverna (incubating) http://orcid.org/0000-0001-9842-9718