From users-return-115293-archive-asf-public=cust-asf.ponee.io@tapestry.apache.org Tue Jul 30 20:37:09 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 83EDF180607 for ; Tue, 30 Jul 2019 22:37:09 +0200 (CEST) Received: (qmail 54134 invoked by uid 500); 30 Jul 2019 20:37:08 -0000 Mailing-List: contact users-help@tapestry.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tapestry users" Delivered-To: mailing list users@tapestry.apache.org Received: (qmail 54117 invoked by uid 99); 30 Jul 2019 20:37:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 30 Jul 2019 20:37:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 2E060C2EDE for ; Tue, 30 Jul 2019 20:37:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.301 X-Spam-Level: ** X-Spam-Status: No, score=2.301 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=2, KAM_NUMSUBJECT=0.5, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamd4-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-he-de.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id BpBk3ARLU_5O for ; Tue, 30 Jul 2019 20:37:03 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2a00:1450:4864:20::243; helo=mail-lj1-x243.google.com; envelope-from=thiagohp@gmail.com; receiver= Received: from mail-lj1-x243.google.com (mail-lj1-x243.google.com [IPv6:2a00:1450:4864:20::243]) by mx1-he-de.apache.org (ASF Mail Server at mx1-he-de.apache.org) with ESMTPS id 591C37DC04 for ; Tue, 30 Jul 2019 20:37:03 +0000 (UTC) Received: by mail-lj1-x243.google.com with SMTP id m8so29776334lji.7 for ; Tue, 30 Jul 2019 13:37:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=Ro8pjtHqh2yttAAzi628LGsinCL3ZwhXIDykgxbE77w=; b=Xdmhb+/BXttM1FFgKkPQ0aAMMIfW2hdROrLai8zqsK5QySW1b7UDgwGJpqmlpjixZI YCia9Jq/X9km9Pv3aQJrKWxPzoE27dYdieRkCu02H3eqnOlzuUSdZViLpOQqPTHghtbC jDt2mb4rzTmfiR9kpH0n5NSADO9jbfMGXb25qhwt4oA9RsMvQYN56RNbPKewwG7Ua1eU xN9doSJ4P3w2dJhDHcW0AEsV4ASyDMxMXH23ZVO/mQxcNpVq77uSA1XnPJnhEx9lM+R+ kfihhyV6sg3e0lE11JLNyD01lRsScXGSWTV3tt4VWsbSB5wfeagG4NpmJFKINN7KtTFP c8XQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=Ro8pjtHqh2yttAAzi628LGsinCL3ZwhXIDykgxbE77w=; b=VcPgSdFK3K1/078qkL33UYPA7Jq4YTcX8UW0FM4+lWcoTCyGLUURzJZKUKcoDbmoc1 hYzjZRUEujxk0SHQLSyl7vq1zEAzp+OaIHWJzaNHUX+WAHnAtTNjqImy+TxWgnqd45X0 buv/7saA5Gk9N6i2/7oVYPdos2Tvy9LpDpXBUZpWlyMrfHO+8J8Q33wi43zheQ5caGqF WI083Z/nb+UZXO8l5mpjss7Ew3pD8xtamX5AlGIeXtcpgklZ6tFwS1ue5uWZYUWeZYWf S4FNjAxViHBxUeXzapw49PTLDJziOTMXa5aL5BerqH+8j3kr6WcLfxxD/rBJePRjVzs/ oq0w== X-Gm-Message-State: APjAAAVWKJ6W1BI7zY4pMEWkC3fovU+nMR8d5aVhwc9a8X0GcUtcjqoA 0ud+fMWQkqNtLWHNEmVbV7dWX7wYDQlLlFymBI1uhQ== X-Google-Smtp-Source: APXvYqwUKTjuRTIFfLfnHxm5p81VXb06ZVGsnK3T8NeSer+Yr6kqlxO1d3XDU6G2PQn0u9vwxMwyapPGOos2UKQnSwI= X-Received: by 2002:a2e:8849:: with SMTP id z9mr22662509ljj.203.1564519021999; Tue, 30 Jul 2019 13:37:01 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: "Thiago H. de Paula Figueiredo" Date: Tue, 30 Jul 2019 17:36:50 -0300 Message-ID: Subject: Re: Proxying default methods does not work with 5.5.0-beta-2 To: Tapestry users Content-Type: multipart/alternative; boundary="0000000000008cfd6d058eebf8d1" --0000000000008cfd6d058eebf8d1 Content-Type: text/plain; charset="UTF-8" On Fri, Jul 12, 2019 at 10:03 AM Chris Poulsen wrote: > Hi > Hello! > I've just gotten around to test our products against Tapestry 5.5 > (master/HEAD) - Everything seems to work fine with the latest code, good > work! > Thanks for the info! > Would it be possible to get a tagged beta (or rc) version published to some > repository that we can rely on for stable builds? > I can see several 5.4 beta/rc versions in central ( > https://mvnrepository.com/artifact/org.apache.tapestry/tapestry-core ), > that would work well for us. I can see a single 5.4-beta on apache staging, > but it seems unclear how long we can expect things to be present in > "staging". > Unless we delete the betas, I'd expect them to be present mostly forever. > > -- > Chris > > On Sat, Jun 22, 2019 at 3:43 AM Thiago H. de Paula Figueiredo < > thiagohp@gmail.com> wrote: > > > I've just committed a fix for this issue. > > > > On Mon, May 6, 2019 at 2:35 PM Oliver Kaiser > > wrote: > > > > > Hi everyone, > > > > > > given something like this: > > > > > > public interface Blub { > > > public default String foo() { > > > return "Default"; > > > } > > > } > > > public class BlubImpl implements Blub { > > > @Override > > > public String foo() { > > > return "Impl"; > > > } > > > } > > > > > > when calling "registry.getService(Blub.class).foo()" using beta-1 this > > > works as expected (BlubImpl is called); when using beta-2 only the > > > default method is called. > > > > > > the log output of PlasticProxyFactory shows that the method is skipped > > > in the generated class > > > > > > seems to be related to this commit > > > > > > > > > https://github.com/apache/tapestry-5/commit/709d282bfc626ce55cde07cbf909c0b86c2b4bcb#diff-89a017b694cffee07e15608bc316d0d7 > > > > > > now "proxyInterface(Class, PlasticMethod)" only > > > calls "introduceInterface(Class, PasticMethod)" (which skips the method > > > as "isDefaultMethod(m)" returns true); earlier versions had an > > > additional for-loop which handled this case (at least from stepping > > > though in a debugger it looks that way) > > > > > > > > > that's a regression, right? > > > > > > > > > btw: thanks to everyone who worked on the 5.4->5.5 transition; updating > > > was very smooth! > > > > > > > > > Regards, > > > Oliver > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: users-unsubscribe@tapestry.apache.org > > > For additional commands, e-mail: users-help@tapestry.apache.org > > > > > > > > > > -- > > Thiago > > > -- Thiago --0000000000008cfd6d058eebf8d1--