tapestry-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Howard M. Lewis Ship (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TAP5-1874) OperationTracker description logging improvement
Date Tue, 02 Jun 2015 00:17:17 GMT

    [ https://issues.apache.org/jira/browse/TAP5-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14568276#comment-14568276
] 

Howard M. Lewis Ship commented on TAP5-1874:
--------------------------------------------

Of course nothing is free; instead of paying the cost of some String creation and String.format()
calls, you are paying immediately for the creation of the inner class instance, plus some
code bloat.

> OperationTracker description logging improvement
> ------------------------------------------------
>
>                 Key: TAP5-1874
>                 URL: https://issues.apache.org/jira/browse/TAP5-1874
>             Project: Tapestry 5
>          Issue Type: Improvement
>          Components: tapestry-ioc
>    Affects Versions: 5.3, 5.4
>            Reporter: Denis Stepanov
>            Priority: Minor
>
> I like the concept of the OperationTracker, but it would be nice if the operation's description
was created only when it's needed. Most of the tapestry code creates the description using
the string concatenating or String.format all the time, but it is only used when an error
occurs or the debug logging is enabled.
> I would suggest to create new interface Operation/OperationInvokable with getDescription
method as the replacement of Runnable/Invokable interface:
>   



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message