tapestry-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jochen Kemnade (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (TAP5-2431) Ajax EventLinks should not cancel the click event
Date Fri, 19 Dec 2014 11:14:13 GMT

    [ https://issues.apache.org/jira/browse/TAP5-2431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14253283#comment-14253283
] 

Jochen Kemnade edited comment on TAP5-2431 at 12/19/14 11:14 AM:
-----------------------------------------------------------------

I proposed a similar patch in TAP5-2162, but it's probably outdated by now.
Regarding the patch, I think the handler methods should not return any value at all.


was (Author: jkemnade):
I proposed a similar patch in TAP5-2162, but it's probably outdated by now.

> Ajax EventLinks should not cancel the click event
> -------------------------------------------------
>
>                 Key: TAP5-2431
>                 URL: https://issues.apache.org/jira/browse/TAP5-2431
>             Project: Tapestry 5
>          Issue Type: Improvement
>          Components: tapestry-core
>    Affects Versions: 5.4
>            Reporter: Chris Poulsen
>            Priority: Minor
>         Attachments: zone-patch.diff
>
>
> Currently the click handlers in zone.js return false to prevent browsers from following
the link. Sometimes this result in unexpected behavior in pages.
> The use-case where we have been hit by this is ajax links in a bootstrap dropdown:
> When a link option is clicked the dropdown does not close again - This is due to the
click event being cancelled.
> The fix that we use locally; is to use event.preventDefault() and let the click event
bubble. 
> I think this should be the default behavior of the framework - as it has much smaller
impact than swallowing the click event and makes the client side things more flexible.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message